Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SearchBar): add price show with hiden filter icon #2425

Merged
merged 1 commit into from
Feb 28, 2022
Merged

feat(SearchBar): add price show with hiden filter icon #2425

merged 1 commit into from
Feb 28, 2022

Conversation

zhengow
Copy link
Contributor

@zhengow zhengow commented Feb 22, 2022

Thank you for your contribution to the KodaDot NFT gallery.
馃憞 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 馃И

Had issue bounty label?

  • Fill up your KSM address: No Need

Community participation

Screenshot

@netlify
Copy link

netlify bot commented Feb 22, 2022

鉁旓笍 Deploy Preview for koda-nuxt ready!

馃敤 Explore the source changes: 8bfb0c7

馃攳 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/621446744a26ea00084796af

馃槑 Browse the preview: https://deploy-preview-2425--koda-nuxt.netlify.app

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it was merged in #2403

@zhengow zhengow closed this Feb 22, 2022
@zhengow zhengow reopened this Feb 22, 2022
@zhengow
Copy link
Contributor Author

zhengow commented Feb 22, 2022

Oh it was merged in #2403

Yes, however because of my another PR revert this feature, and this one doesn't apply into beta env. So that's why i PR again

image

@petersopko petersopko mentioned this pull request Feb 22, 2022
17 tasks
@yangwao yangwao merged commit d6ac2c9 into kodadot:main Feb 28, 2022
@zhengow zhengow deleted the issue_2400 branch March 3, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show price range next to the filter
3 participants