-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add item column and relative time to history #2552
Conversation
鉁旓笍 Deploy Preview for koda-nuxt ready! 馃敤 Explore the source changes: 04376c7 馃攳 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/623209806a85e70008ad395a 馃槑 Browse the preview: https://deploy-preview-2552--koda-nuxt.netlify.app |
Probably #2545 broke something here 馃憖 |
My mac has frozen. |
@kkukelka may update your PR with the latest main? |
Maybe you drank too much club mate? |
done |
I sense that pagination doesn't work here? almost frozen my stuff https://deploy-preview-2552--koda-nuxt.netlify.app/rmrk/collection/b45071647155359951-SUBSTRA?tab=history&page=5 yup this how it should look like |
clicked update branch, let's see? |
Schumacher, seems lots of caffeine today lol otherwise, it's working? Screen.Recording.2022-03-16.at.14.54.07.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh found bug, link to item doesn't work |
Good eye! {
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052",
"events": [
{
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052-MINTNFTKZ6hxTeIVTR8CKEx1UGac"
},
{
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052-LISTVg-SA9ZqfMYVyNOq0TRRy"
},
{
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052-BUYpfpKvJxNHW2JrskhHZoDM"
},
{
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052-LISTQDPhuXFgDiG2C42oehjeQ"
},
{
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052-BUYLSmNCpMZBeiwl2CHMj7Uu"
},
{
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052-LISTRWcsa83ZhcXY3dTLX81su"
},
{
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052-LISTXXxJ1lYPxRa8uf7uTg4m2"
},
{
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052-LISTeBoxa_zCzB9uig5eWfKif"
},
{
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052-LISTwINca_XiQf6yN1mMZJwRB"
},
{
"id": "9181565-dac5c7f54029d0e73c-HXAI8-E_V_EM-0000000000000052-LISTSC43fZxm5Mg1XE4_Eyduh"
}
]
} @kkukelka fast fix is to remove everything after the last dash const reg = /-[a-zA-Z0-9_]+$/
id.replace(reg, '') |
Better approach is to select name and id from NFT :) |
gonna opt for regex as i dont have time update graphql query event['Item'] = newEvent['id']?.replace(
/-(BUY|CONSUME|LIST|MINT|MINFNFT|SEND).+$/,
''
) also made sure not to show item column on NFT Detail page |
Add the name of the item to the history, once it would be available. |
pay 100 usd |
馃槏 Perfect, I鈥檝e sent the payout 馃獏 Let鈥檚 grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
馃憞 _ Let's make a quick check before the contribution.
history.mov
PR type
What's new?
Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot