Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2539 Post fixes in sales feed of collection #2567

Merged
merged 4 commits into from
Mar 19, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Mar 17, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2022-03-17 at 1 03 11 PM

@netlify
Copy link

netlify bot commented Mar 17, 2022

✔️ Deploy Preview for koda-nuxt ready!

🔨 Explore the source changes: c60dd7c

🔍 Inspect the deploy log: https://app.netlify.com/sites/koda-nuxt/deploys/623358d795917a0009102e6a

😎 Browse the preview: https://deploy-preview-2567--koda-nuxt.netlify.app

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. missing responsive first column.
Screenshot 2022-03-17 at 09-02-34 Kitty Paradise

I'd like to see if it's possible to use a non-breaking space instead of a css solution.

components/rmrk/Gallery/History.vue Outdated Show resolved Hide resolved
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@vikiival
Copy link
Member

^-^

@prachi00
Copy link
Member Author

Code looks good. missing responsive first column. Screenshot 2022-03-17 at 09-02-34 Kitty Paradise

I'd like to see if it's possible to use a non-breaking space instead of a css solution.

@roiLeo can you send the collection url where this is happening? For me it is like this
Screenshot 2022-03-17 at 3 16 44 PM

@roiLeo
Copy link
Contributor

roiLeo commented Mar 17, 2022

@roiLeo can you send the collection url where this is happening?

Tested on: /rmrk/collection/800f8a914281765a7d-KITTY?tab=history

Have you tried to resize your browser? You can open dev console on right side and you'll be able to resize

@prachi00
Copy link
Member Author

@roiLeo have fixed the issue

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it's working too bad it's not possible to use a &nbsp; char

@yangwao
Copy link
Member

yangwao commented Mar 17, 2022

pay 100 usd

let's merge it whenever done )

@yangwao
Copy link
Member

yangwao commented Mar 17, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 131.9 USD/KSM ~ 0.758 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x65d815842f3af5ab3ee51161f485d91673ff7413c92b3b3bc8e62060a8462247

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 17, 2022
@prachi00
Copy link
Member Author

Well it's working too bad it's not possible to use a &nbsp; char

use this where? Did not get it

@roiLeo
Copy link
Contributor

roiLeo commented Mar 17, 2022

Well it's working too bad it's not possible to use a &nbsp; char

use this where? Did not get it

I was thinking to use it (or another utf8 char) directly in translation file but I don't know if it would work out

@prachi00
Copy link
Member Author

Well it's working too bad it's not possible to use a &nbsp; char

use this where? Did not get it

I was thinking to use it (or another utf8 char) directly in translation file but I don't know if it would work out

umm yeah probably not sure how to do that tho

@yangwao yangwao merged commit 1fe1e54 into kodadot:main Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post fixes in sales feed of collection
4 participants