fallback nft meta is null

[Jarsen136]

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

• Bugfix
• Feature
• Refactoring

What's new?

• PR closes Seems newest list from landing is gone  #2747
• <brief_description_of_what_I've_added>

the error is caused by the incrooect nft meta, which id is null.

the nft: /rmrk/gallery/10869444-c6017764e7a1d03b5e-MOOSENFT-MAGGIE_MOOSE_29-0000000000000029

expected nft meta is an object with id and image.

Would be cool if we can filter the events in squid.

Before submitting Pull Request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality
• I've posted a screenshot of demonstrated change in this PR

Optional

• I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
• I've tested PR on mobile and everything seems works
• I found edge cases
• I've written some unit tests 🧪

Had issue bounty label?

• Fill up your KSM address: Payout

Community participation

• Are you at KodaDot Discord?

Screenshot

• My fix has changed something on UI; a screenshot is best to understand changes for others.

[netlify]

❌ Deploy Preview for koda-nuxt failed.

Name	Link
🔨 Latest commit	839c83b
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/62554a7806c0270008e7f412

[vikiival]

fallback

fallback is when you ask one girl for a date but in case you ask another girl just in case the first one would say no

The implementation filters out nfts which does not have meta (which is super strange :)) But the correct fallback is to take metadata field and fetch it on the client

[Jarsen136]

I mock the empty meta and then it displays all the images and works well without any error.

[vikiival]

Extend queries/rmrk/subsquid/lastNftListByEvent.graphql

1. extend query with metadata

query lastNftListByEvent($limit: Int!, $event: Interaction!, $and: [EventWhereInput!]) {
  events(
    limit: $limit
    where: { interaction_eq: $event, AND: $and, nft: {burned_eq: false} }
    orderBy: timestamp_DESC
  ) {
    meta
    timestamp
    nft {
      id
      name
      issuer
      currentOwner
      metadata
      meta {
        id
        image
      }
    }
  }
}

2. fetch metadata
3. update cache
4. fetch image via cloudflare image

[yangwao]

lol probably accidentally found that moment lol and seems working

[Jarsen136]

lol probably accidentally found that moment lol and seems working

yup, you caught the same error again 😄

[Jarsen136]

Extend queries/rmrk/subsquid/lastNftListByEvent.graphql

1. extend query with metadata

query lastNftListByEvent($limit: Int!, $event: Interaction!, $and: [EventWhereInput!]) {
  events(
    limit: $limit
    where: { interaction_eq: $event, AND: $and, nft: {burned_eq: false} }
    orderBy: timestamp_DESC
  ) {
    meta
    timestamp
    nft {
      id
      name
      issuer
      currentOwner
      metadata
      meta {
        id
        image
      }
    }
  }
}

2. fetch metadata
3. update cache
4. fetch image via cloudflare image

Now it works for me but I'm not sure if the code meets your expectation.
And I still don't know how I try to fetch meta.image if 'meta' is null. 😕

[vikiival]

👀

[yangwao]

Are conversations resolved?

[vikiival]

YOLO MODE ON.

[vikiival]

pay 99 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $99 @ 156.21 USD/KSM ~ 0.634 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x9584cedba95dc54eb2dec18c4c0e176c21feb8182f809f9a566acc51f0d67bb2

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues