Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve random button and pagination #2850

Merged
merged 7 commits into from
Apr 14, 2022
Merged

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner April 14, 2022 01:34
@Jarsen136 Jarsen136 requested review from roiLeo and removed request for a team April 14, 2022 01:34
@netlify
Copy link

netlify bot commented Apr 14, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 988ded5
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6258407cda9d1600093a1fa5
😎 Deploy Preview https://deploy-preview-2850--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Apr 14, 2022

It works but It's still weird because the page automatically loads the next page of content : )

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing:

  • hideSearch bar
  • fix sort & listed

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Apr 14, 2022

update:

  • hideSearch bar
  • fix sort & listed

image

I found another problem:

Some sort options do not work well.
'new first' 'old first' works well but the others dont. Maybe related to #2718 Do you have any ideas? 👀 @roiLeo
image

image

image

@roiLeo
Copy link
Contributor

roiLeo commented Apr 14, 2022

I found another problem:

Some sort options do not work well. 'new first' 'old first' works well but the others dont. Maybe related to #2718 Do you have any ideas? 👀

enum CollectionEntityOrderByInput {
  version_ASC
  version_DESC
  name_ASC
  name_DESC
  max_ASC
  max_DESC
  issuer_ASC
  issuer_DESC
  symbol_ASC
  symbol_DESC
  id_ASC
  id_DESC
  metadata_ASC
  metadata_DESC
  currentOwner_ASC
  currentOwner_DESC
  blockNumber_ASC
  blockNumber_DESC
  meta_id_ASC
  meta_id_DESC
  meta_name_ASC
  meta_name_DESC
  meta_description_ASC
  meta_description_DESC
  meta_image_ASC
  meta_image_DESC
  meta_animationUrl_ASC
  meta_animationUrl_DESC
  meta_type_ASC
  meta_type_DESC
  createdAt_ASC
  createdAt_DESC
}

looks like updateAt is missing in collection we might need to filter on NFTEntityOrderByInput instead

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Apr 14, 2022

looks like updateAt is missing in collection we might need to filter on NFTEntityOrderByInput instead

Sorry but I still don't understand what should I do to fix it. Could you pls expand more?

@roiLeo
Copy link
Contributor

roiLeo commented Apr 14, 2022

looks like updateAt is missing in collection we might need to filter on NFTEntityOrderByInput instead

Sorry but I still don't understand what should I do to fix it. Could you pls expand more?

For the moment I don't have a quick solution but basically we can't sort CollectionEntity by updatedAt, we'll need to edit the graphql query to sort by updateAt on NFTEntity.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove isEqual import since it's not used anymore?

@Jarsen136
Copy link
Contributor Author

For the moment I don't have a quick solution but basically we can't sort CollectionEntity by updatedAt, we'll need to edit > the graphql query to sort by updateAt on NFTEntity.

How about removing these unSupported sort options?
'Last interacted' and 'Least Interacted'

could you remove isEqual import since it's not used anymore?

Sure, I have done

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ tested

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested one more thing

https://deploy-preview-2850--koda-nuxt.netlify.app/rmrk/explore?page=1&search=&sort=blockNumber_ASC&listed=true

should show me "Old first" but it show me the newest

@Jarsen136
Copy link
Contributor Author

Tested one more thing

https://deploy-preview-2850--koda-nuxt.netlify.app/rmrk/explore?page=1&search=&sort=blockNumber_ASC&listed=true

should show me "Old first" but it show me the newest

I have fixed it just now.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pay 100

@roiLeo
Copy link
Contributor

roiLeo commented Apr 14, 2022

hmmmmm???

@roiLeo roiLeo merged commit 9f75197 into kodadot:main Apr 14, 2022
@roiLeo
Copy link
Contributor

roiLeo commented Apr 14, 2022

pay 100

@yangwao
Copy link
Member

yangwao commented Apr 14, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 158.42 USD/KSM ~ 0.631 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xe5543faa1fe45d6f70380864c6de9617957e260705fbdb5d6bfd8243dbf132ce

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve random button and pagination
3 participants