Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ show emoteCount & sort by most reacted #2936

Merged
merged 3 commits into from
May 2, 2022
Merged

✨ show emoteCount & sort by most reacted #2936

merged 3 commits into from
May 2, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented May 2, 2022 •
edited
Loading

PR type

  • Feature

What's new?

  • PR related with Show NFTs by most emoted  #1174
  • display emote on nft card in /rmrk/collection/{id}
  • display emote on nft card in /rmrk/u/{id}
  • sort by "Most Reacted"

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>

Screenshot

Capture d’écran 2022-05-02 à 9 09 16 AM

Capture d’écran 2022-05-02 à 9 08 46 AM

Capture d’écran 2022-05-02 à 2 41 11 PM

@roiLeo roiLeo requested a review from a team as a code owner May 2, 2022 07:13
@roiLeo roiLeo requested review from kkukelka and removed request for a team May 2, 2022 07:13
@netlify
Copy link

netlify bot commented May 2, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 6038518
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/626fd1eebbb29a0008b4c967
😎 Deploy Preview https://deploy-preview-2936--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo changed the title ✨ show emoteCount & sort by most reacted on collection/id ✨ show emoteCount & sort by most reacted May 2, 2022
kkukelka
kkukelka approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, very cool addition to the filter section 👍

@kkukelka kkukelka merged commit 28e9aef into kodadot:main May 2, 2022
@kkukelka
Copy link
Member

kkukelka commented May 2, 2022

pay 75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkukelka kkukelka kkukelka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roiLeo @kkukelka