Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 Passion at explorer feed #3082

Merged
merged 13 commits into from
May 29, 2022
Merged

🚑 Passion at explorer feed #3082

merged 13 commits into from
May 29, 2022

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented May 29, 2022

  • fix: translation incorrect on loader when minting
  • fix: message box bg
  • chore: updated readme with public good writing
  • chore: cleanup old assets
  • fix: dont crash page upon failed request
  • fix: only fetch data if loggedin
  • fix: only show switch when logged in

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@yangwao yangwao requested a review from a team as a code owner May 29, 2022 12:30
@yangwao yangwao requested review from kkukelka and removed request for a team May 29, 2022 12:30
@netlify
Copy link

netlify bot commented May 29, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 85c6f57
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6293677f9024a100089e832b
😎 Deploy Preview https://deploy-preview-3082--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao yangwao merged commit 802e7e3 into hyper-jpeg May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants