Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 stats by profile Id (bsx) #3257

Merged
merged 6 commits into from
Jun 24, 2022
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Jun 23, 2022

test on /bsx/u/bXhWeVLtArWauM8UmbaVdDmXmo5uSDk6DAa2YxQ5zbt2sDcbW

PR type

  • Bugfix

What's new?

  • profileStatsById for bsx chain

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot

before
Screenshot 2022-06-23 at 16-50-30 NFT Artist Profile on KodaDot KodaDot - Kusama NFT Market Explorer

after
Screenshot 2022-06-24 at 09-51-47 NFT Artist Profile on KodaDot KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner June 23, 2022 15:17
@roiLeo roiLeo requested review from petersopko and removed request for a team June 23, 2022 15:17
@netlify
Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 8d0bc98
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62b600ab751f8e0009e3ed72
😎 Deploy Preview https://deploy-preview-3257--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo mentioned this pull request Jun 23, 2022
7 tasks
@roiLeo roiLeo marked this pull request as draft June 23, 2022 15:30
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 23, 2022

doesn't work yet :/
edit: fixed

@roiLeo roiLeo marked this pull request as ready for review June 24, 2022 07:55
@petersopko
Copy link
Contributor

hey, just tested this, seems that there are still irregularities within the stats? check the screenshot below
image

Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls double check, for example, buys / highest buy doesn't correspond. tested at bXkVgiXLvvJAmUNni8huN9NZdjaxKGav9fSszhRXFeg6Xuvih

@petersopko petersopko added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jun 24, 2022
@roiLeo
Copy link
Contributor Author

roiLeo commented Jun 24, 2022

hey, just tested this, seems that there are still irregularities within the stats? check the screenshot below image

This might be a backend issue, we should have same data type between subsquid different implementation

more infos:
on RMRK => event: "BUY", meta key has nft price
Capture d’écran 2022-06-24 à 12 03 18 PM

on BSX => event: "BUY", meta key doesn't have nft price
Capture d’écran 2022-06-24 à 12 02 58 PM

@petersopko
Copy link
Contributor

more infos: on RMRK => event: "BUY", meta key has nft price Capture d’écran 2022-06-24 à 12 03 18 PM

on BSX => event: "BUY", meta key doesn't have nft price Capture d’écran 2022-06-24 à 12 02 58 PM

ok let's merge this one, referenced this issue here kodadot/snek#33

@petersopko petersopko added the A-basilisk issues related to basilisk parachain label Jun 24, 2022
@petersopko petersopko merged commit 0f99dba into kodadot:main Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-basilisk issues related to basilisk parachain S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants