Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: transfer shows address twice #3357

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Conversation

zhengow
Copy link
Contributor

@zhengow zhengow commented Jul 6, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </transfer?target=EgCzZLpVe7zg7RHh79qPyC8UrykVkA22YY2oj7sWMZf15Ws>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image

@zhengow zhengow requested a review from a team as a code owner July 6, 2022 17:13
@zhengow zhengow requested review from kkukelka and removed request for a team July 6, 2022 17:13
@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 702ffde
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62c6665072e7ac000852ed4e
😎 Deploy Preview https://deploy-preview-3357--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but one question

components/shared/format/Identity.vue Show resolved Hide resolved
@kkukelka kkukelka merged commit 086bd3b into kodadot:main Jul 7, 2022
@kkukelka
Copy link
Member

kkukelka commented Jul 7, 2022

pay 50

@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 51.61 USD/KSM ~ 0.969 $KSM
🧗 EgCzZLpVe7zg7RHh79qPyC8UrykVkA22YY2oj7sWMZf15Ws
🔗 0x317882cb5e56a44083bd0ae73dc1d68d40762937a9153e73332eb537c3c90ec4

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 7, 2022
@Jarsen136 Jarsen136 mentioned this pull request Jul 7, 2022
18 tasks
@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

hey seems this PR introduced some bug tho, which was fixed in #3369

but rewarding your effort tho! :)
pay 30 usd

@yangwao yangwao removed the paid pull-request has been paid label Jul 7, 2022
@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

😍 Perfect, I’ve sent the payout
💵 $30 @ 52.58 USD/KSM ~ 0.571 $KSM
🧗 EgCzZLpVe7zg7RHh79qPyC8UrykVkA22YY2oj7sWMZf15Ws
🔗 0x9b8e70568c8f7ebf7aca4efe6b80bab2ccf5607546a1e244134111b84018d154

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transfer shows address twice
3 participants