Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFT Storage is here #3358

Merged
merged 16 commits into from
Jul 7, 2022
Merged

NFT Storage is here #3358

merged 16 commits into from
Jul 7, 2022

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Jul 6, 2022

  • ⚡ added nft-storage worker
  • ⚡ implemented nft-storage
  • ⚡ use NFT-Storage for Basilisk
  • ⚡ should refresh token if user had legacy ESTUARY one
  • ⚡ RMRK is using Nft storage
  • ⚡ unique is using nft storage
  • ⚡ app is doing direct upload

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • Requires deployment <rubick/magick_issue>
  • <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

@vikiival vikiival requested a review from a team as a code owner July 6, 2022 18:40
@vikiival vikiival requested review from prachi00 and removed request for a team July 6, 2022 18:40
@vikiival vikiival self-assigned this Jul 6, 2022
@vikiival vikiival requested review from yangwao and a team July 6, 2022 18:40
@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 92a2f73
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62c6acf36bffce0009094baf
😎 Deploy Preview https://deploy-preview-3358--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vikiival vikiival requested a review from petersopko July 7, 2022 08:15
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nftStorage definitely looks like something that can be moved in services folder (ref #3310)

By the way I find something strange, $nuxt.context should be accessible from this file but it's not, do you have any idea why?

utils/nftStorage.ts Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

right away seems it works well yet, immediately returns 500 but reloading right away wfm

Screenshot 2022-07-07 at 10 53 40

@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

now it worked that returned metadata but no picture even after reload and w/o error, strange

image

@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

lmao, one can't simply think of this

image

image

@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

Seems right away now it has worked, but doubt it could be the case every time.

I would suggest it fetch it through pinata on the background one more time while minting has finished.

And delay user going to fresh mint to like 5 seconds

image

@petersopko
Copy link
Contributor

minted collection and it's visible with name right away, seems to be closing

redirected to minting NFT after which minted NFT shows up right away:
image

https://deploy-preview-3358--koda-nuxt.netlify.app/bsx/gallery/2600576003-1

@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

lgtm, works right away after mint.
has someone tested it for rmrk?

@vikiival
Copy link
Member Author

vikiival commented Jul 7, 2022

has someone tested it for rmrk?

Magick

@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

Worked well on rmrk, but yet

@yangwao
Copy link
Member

yangwao commented Jul 7, 2022

The only downside at the current implementation we are limited to 100MB per file until we rework it so that clients push it directly to NFT storage endpoint

image

@yangwao yangwao enabled auto-merge July 7, 2022 10:56
@yangwao yangwao disabled auto-merge July 7, 2022 10:57
@yangwao yangwao merged commit bccb944 into main Jul 7, 2022
@yangwao yangwao deleted the nft-storage branch July 7, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants