Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smol after fix with identity #3371

Merged
merged 22 commits into from
Jul 7, 2022
Merged

Smol after fix with identity #3371

merged 22 commits into from
Jul 7, 2022

Conversation

yangwao
Copy link
Member

@yangwao yangwao commented Jul 7, 2022

  • ⚑ moonsama url should be present
  • πŸŽ‰ copypasted moonsama from bsx
  • ⚑ expect that default indexer is subsquid
  • πŸ”§ moonsama indexer config
  • πŸ” moonsama detail :)
  • πŸ› metadata can override id
  • ⚑ added click
  • πŸŽ‰ copy-paste moonsama here
  • ⚑ correct build platform for moonsama
  • ⚰️ removed available actions
  • ⚑ formatter to evm addr
  • ⚑ utiiiiils
  • ⚑ create only visible based on the configuration
  • 🧼 renamed copy-pasted components from BSX to moonsama
  • πŸ› query path resolver breaks magick
  • 🧼 fixed deepscan
  • fix: Identity at item is shown twice

Thank you for your contribution to the KodaDot NFT gallery.
πŸ‘‡ _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes #<issue_number>
  • Requires deployment <rubick/magick_issue>
  • <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests πŸ§ͺ

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@yangwao yangwao requested a review from a team as a code owner July 7, 2022 14:55
@yangwao yangwao requested review from kkukelka and removed request for a team July 7, 2022 14:55
@netlify
Copy link

netlify bot commented Jul 7, 2022

βœ… Deploy Preview for koda-nuxt ready!

Name Link
πŸ”¨ Latest commit 6f6dbe0
πŸ” Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62c6f3fcbf43610009672d50
😎 Deploy Preview https://deploy-preview-3371--koda-nuxt.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao yangwao merged commit 4d5fa4b into hyper-jpeg Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants