Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Keep top border only on action buttons for on-chain actions #3373

Merged
merged 16 commits into from
Jul 17, 2022
Merged

feat: Keep top border only on action buttons for on-chain actions #3373

merged 16 commits into from
Jul 17, 2022

Conversation

zhengow
Copy link
Contributor

@zhengow zhengow commented Jul 7, 2022 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/gallery/11691581-5CF5F9BFDD3678C178-ZCSYMBOL-ZCNAME-0000000000000001>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image

@zhengow zhengow requested a review from a team as a code owner July 7, 2022 17:12
@zhengow zhengow requested review from Jarsen136 and removed request for a team July 7, 2022 17:12
@kodabot
Copy link
Collaborator

kodabot commented Jul 7, 2022

SUCCESS @zhengow PR for issue #3363 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Jul 7, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 7e382e6
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62d3c19b395be80008581d37
😎 Deploy Preview https://deploy-preview-3373--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo self-requested a review July 7, 2022 18:12
Jarsen136
Jarsen136 reviewed Jul 8, 2022
View reviewed changes
components/rmrk/Gallery/Item/Sharing.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/Item/Sharing.vue Outdated Show resolved Hide resolved
utils/shoppingActions.ts Show resolved Hide resolved
@zhengow
Copy link
Contributor Author

zhengow commented Jul 8, 2022

@Jarsen136
great idea, thx.
Already fix, pls check again.

@yangwao
Copy link
Member

yangwao commented Jul 8, 2022

have you checked it on BSX as well?

image

@zhengow
Copy link
Contributor Author

zhengow commented Jul 8, 2022 •
edited
Loading

have you checked it on BSX as well?

image

My mistake. Already fix it.
image

Also update unique

@Jarsen136
Copy link
Contributor

Jarsen136 commented Jul 9, 2022 •
edited
Loading

I could download any nft even though I'm not its owner.

https://deploy-preview-3373--koda-nuxt.netlify.app/rmrk/gallery/10281449-72544d5b203a79d527-DBE6E-STREET_IN_CETINJE-0000000000000003
image

User could only download his own nft.
Pls fix this bug.

@Jarsen136 Jarsen136 added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 9, 2022
@zhengow
Copy link
Contributor Author

zhengow commented Jul 9, 2022

I could download any nft even though I'm not its owner.

https://deploy-preview-3373--koda-nuxt.netlify.app/rmrk/gallery/10281449-72544d5b203a79d527-DBE6E-STREET_IN_CETINJE-0000000000000003

image

User could only download his own nft.

Pls fix this bug.

Emmm, but user could still download nft in other way?👀
Still need to fix this?

@Jarsen136
Copy link
Contributor

Emmm, but user could still download nft in other way?👀

Yes, but we should not provide that button.
ref: #2557

@yangwao
Copy link
Member

yangwao commented Jul 9, 2022

Emmm, but user could still download nft in other way?👀

yeah, we "disabled right-click", but of course, through the console, it would be possible.

Still need to fix this?

@Jarsen136 meant you should check the same condition if a user is the owner of it as it was in shopping actions iirc :)

@zhengow
Copy link
Contributor Author

zhengow commented Jul 9, 2022

got it. I will fix it later

@zhengow
Copy link
Contributor Author

zhengow commented Jul 9, 2022

Emmm, but user could still download nft in other way?👀

Yes, but we should not provide that button. ref: #2557

Already hidden it, pls check:)

roiLeo
roiLeo reviewed Jul 9, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have a $sleek-primary-border that can do the work

components/rmrk/Gallery/AvailableActions.vue Outdated Show resolved Hide resolved
components/bsx/Gallery/Item/AvailableActions.vue Outdated Show resolved Hide resolved
components/rmrk/Gallery/Item/ActionList.vue Outdated Show resolved Hide resolved
@zhengow
Copy link
Contributor Author

zhengow commented Jul 10, 2022

we already have a $sleek-primary-border that can do the work

Fix it by refactor only-border-top scss to @/styles/border.scss and import them where it need.
However, I think $sleek-primary-border can't be used cuz each button has different color, and it need to hidden other three border. How do u think?

@yangwao
Copy link
Member

yangwao commented Jul 11, 2022

hey I've noticed in this PR I can make offer on own NFT
https://deploy-preview-3373--koda-nuxt.netlify.app/bsx/gallery/3606678538-1
image

seems on https://beta.kodadot.xyz/bsx/gallery/3606678538-1 it's ok
image

just noticed it now

@yangwao
Copy link
Member

yangwao commented Jul 13, 2022

@zhengow let's merge upstream and fix conflicts, maybe my last issues was fixed meanwhile :)

@zhengow
Merge branch 'main' of https://github.com/kodadot/nft-gallery
1c4a8be 
# Conflicts:
#	components/bsx/Gallery/Item/AvailableActions.vue
#	components/bsx/Gallery/Item/GalleryItem.vue
@zhengow zhengow requested a review from a team as a code owner July 16, 2022 05:29
@zhengow zhengow requested review from JustLuuuu and removed request for a team July 16, 2022 05:29
@zhengow
Copy link
Contributor Author

zhengow commented Jul 16, 2022

@zhengow let's merge upstream and fix conflicts, maybe my last issues was fixed meanwhile :)

Already fix the bug, pls check again:)
image

image

Jarsen136
Jarsen136 approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

LGTM

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jul 16, 2022
petersopko
petersopko suggested changes Jul 16, 2022
View reviewed changes
Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check share button on rmrk

@petersopko
Copy link
Contributor

rmrk, on nft I bought 👀

image

@petersopko petersopko added S-changes-requested-🤞 PR is almost good to go, just some fine tunning and removed S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved labels Jul 16, 2022
@zhengow
Copy link
Contributor Author

zhengow commented Jul 16, 2022

image

Done

@petersopko petersopko added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Jul 17, 2022
@petersopko
Copy link
Contributor

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Jul 17, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 56.54 USD/KSM ~ 1.769 $KSM
🧗 EgCzZLpVe7zg7RHh79qPyC8UrykVkA22YY2oj7sWMZf15Ws
🔗 0xf91c887411fa3be200c1081bac434b702d05a1ede0db15ac4c71faa7bc1f295f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@petersopko petersopko merged commit 935d3de into kodadot:main Jul 17, 2022
@yangwao yangwao added the paid pull-request has been paid label Jul 17, 2022
@Jarsen136 Jarsen136 mentioned this pull request Jul 21, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo left review comments

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@petersopko petersopko petersopko approved these changes

@JustLuuuu JustLuuuu Awaiting requested review from JustLuuuu JustLuuuu was automatically assigned from kodadot/qa-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep top border only on action buttons for on-chain actions
6 participants
@zhengow @kodabot @yangwao @Jarsen136 @petersopko @roiLeo