Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3433 Search bar suggestions changes #3491

Merged
merged 6 commits into from
Jul 21, 2022
Merged

#3433 Search bar suggestions changes #3491

merged 6 commits into from
Jul 21, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Jul 20, 2022 •
edited
Loading

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2022-07-19 at 7 36 31 PM

@prachi00 prachi00 requested review from a team as code owners July 20, 2022 02:37
@prachi00 prachi00 requested review from Jarsen136 and damskyftw and removed request for a team July 20, 2022 02:37
@kodabot
Copy link
Collaborator

kodabot commented Jul 20, 2022

WARNING @prachi00 PR for issue #3433 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3433

@netlify
Copy link

netlify bot commented Jul 20, 2022 •
edited
Loading

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 101a46a
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/62d9b2c2d386b10008de7700
😎 Deploy Preview https://deploy-preview-3491--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prachi00 prachi00 requested a review from petersopko July 20, 2022 02:38
damskyftw
damskyftw approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@damskyftw damskyftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

petersopko
petersopko suggested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I'm clicking on suggested item from landing page, I'm weirdly redirected to search of the term I've typed in, not to the actual item.
Also this shows up:
image

@petersopko petersopko added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 20, 2022
@damskyftw damskyftw added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Jul 20, 2022
@prachi00
Copy link
Member Author

when I'm clicking on suggested item from landing page, I'm weirdly redirected to search of the term I've typed in, not to the actual item. Also this shows up: image

@petersopko try now. should work

@petersopko petersopko mentioned this pull request Jul 21, 2022
Closed
@petersopko
Copy link
Contributor

@petersopko try now. should work

ok, the routing and suggestions now works as expected, last bit following up in here:

@petersopko petersopko removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Jul 21, 2022
@petersopko
Copy link
Contributor

let's wait until @Jarsen136 checks the code and merge if there's nothing left to fix :)

This was referenced Jul 21, 2022
Closed
Closed
@prachi00
Copy link
Member Author

pay 100 usd

@yangwao
Copy link
Member

yangwao commented Jul 21, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 61.49 USD/KSM ~ 1.626 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xf32b1ee94897e14378fcc86de4b9d916c982a13c2c9d922e30fc9e6be306830b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Jul 21, 2022
@prachi00 prachi00 merged commit 44b185e into main Jul 21, 2022
@prachi00 prachi00 deleted the feat-bsx-search-query branch July 21, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 left review comments

@petersopko petersopko petersopko approved these changes

@damskyftw damskyftw damskyftw approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search bar suggestions in explore/collections
6 participants
@prachi00 @kodabot @petersopko @yangwao @Jarsen136 @damskyftw