Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search bar with suggestion on mobile #3996

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested review from a team as code owners September 21, 2022 16:13
@Jarsen136 Jarsen136 requested review from roiLeo and petersopko and removed request for a team September 21, 2022 16:13
@kodabot
Copy link
Collaborator

kodabot commented Sep 21, 2022

SUCCESS @Jarsen136 PR for issue #3882 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Sep 21, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 1005fbb
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/632d04a3cd3fe4000805204a
😎 Deploy Preview https://deploy-preview-3996--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Jarsen136 Jarsen136 changed the title feat: search bar on mobile feat: search bar with suggestion on mobile Sep 21, 2022
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrows on Gallery Item overlaps
Capture d’écran 2022-09-22 à 9 10 29 AM

When I click on an Item I'm redirected but I still see the searchbar open
Capture d’écran 2022-09-22 à 9 12 46 AM

When I click on "x" I except the searchInput to be empty/erased

@codeclimate
Copy link

codeclimate bot commented Sep 23, 2022

Code Climate has analyzed commit 1005fbb and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

✅ Fixed: Arrows on Gallery Item overlaps

image

@Jarsen136
Copy link
Contributor Author

Jarsen136 commented Sep 23, 2022

As for these two bugs, I create another issue for them. I guess it may need some tricky fixes.

  • When I click on an Item I'm redirected but I still see the searchbar open
  • When I click on "x" I except the searchInput to be empty/erased

Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@yangwao
Copy link
Member

yangwao commented Sep 23, 2022

pay 50

@yangwao yangwao merged commit 2397265 into kodadot:main Sep 23, 2022
@yangwao
Copy link
Member

yangwao commented Sep 23, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 40.96 USD/KSM ~ 1.221 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x3689695b33e0972604ea0c3353b1a28913550466a3fa87486e0d93f524a8d811

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Bar on mobile
5 participants