Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image previews on moonriver #4027

Merged
merged 9 commits into from
Sep 27, 2022
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Sep 26, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2022-09-26 at 09 16 10

Screen Shot 2022-09-26 at 09 16 19

@kodabot
Copy link
Collaborator

kodabot commented Sep 26, 2022

WARNING @preschian PR for issue #3952 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3952

@kodabot
Copy link
Collaborator

kodabot commented Sep 26, 2022

SUCCESS @preschian PR for issue #4020 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Sep 26, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 6dedfb8
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6332eb1e4a70650008c89f47
😎 Deploy Preview https://deploy-preview-4027--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

components/rmrk/utils.ts Outdated Show resolved Hide resolved
@preschian
Copy link
Member Author

preschian commented Sep 26, 2022

some collection image was still using a placeholder because the metadata was null, maybe we need to fix that from the indexer?

and, I don't know how to fix this deepsource issue https://deepsource.io/gh/kodadot/nft-gallery/run/403d3893-71a4-4cf4-92a0-0882e1129d9a/javascript/JS-0336?listindex=1

another error from deepsource Detected the use of variables before they are defined. should I fix that in this PR or in the separate PR? I think we should put the eslint rule for that https://eslint.org/docs/latest/rules/no-use-before-define

@preschian preschian marked this pull request as ready for review September 26, 2022 02:43
@preschian preschian requested review from a team as code owners September 26, 2022 02:43
@preschian preschian requested review from Jarsen136 and petersopko and removed request for a team September 26, 2022 02:43
@petersopko
Copy link
Contributor

yeah wfm, except for this:

some collection image was still using a placeholder because the metadata was null, maybe we need to fix that from the indexer?

perhaps related to this created issue

I think this is good solution until the indexer get's fixed?

@preschian
Copy link
Member Author

perhaps related to this created issue

I think this is good solution until the indexer get's fixed?

I see, yes I think so. I just realized this PR should fix this issue also #3338
that error occurs when we set idb-keyval with a null as a key, for example: get(null, data)

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff

components/rmrk/utils.ts Show resolved Hide resolved
@petersopko
Copy link
Contributor

@preschian let's check that deepsrouce issue and other than that, I think let's merge this to have some previews ready

Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petersopko petersopko added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Sep 27, 2022
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Sep 27, 2022
@petersopko
Copy link
Contributor

pay 50 usd

@codeclimate
Copy link

codeclimate bot commented Sep 27, 2022

Code Climate has analyzed commit 6dedfb8 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Sep 27, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 45 USD/KSM ~ 1.111 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0x506e82136b2a226545f739f2ff511f82cbb70fb8083050ae2f1483e9a79ffd4c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Sep 27, 2022
@petersopko petersopko merged commit 01126c5 into main Sep 27, 2022
@petersopko petersopko deleted the fix-image-previews-moonriver branch September 27, 2022 12:30
@petersopko
Copy link
Contributor

looks like auto-merge doesn't care about some of the deepsource issues which jumped out again after merging main into this, it doesn't look that serious, let's catch it elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
5 participants