-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: image previews on moonriver #4027
Conversation
WARNING @preschian PR for issue #3952 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3952 |
SUCCESS @preschian PR for issue #4020 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
some collection image was still using a placeholder because the metadata was and, I don't know how to fix this deepsource issue https://deepsource.io/gh/kodadot/nft-gallery/run/403d3893-71a4-4cf4-92a0-0882e1129d9a/javascript/JS-0336?listindex=1 another error from deepsource |
yeah wfm, except for this:
perhaps related to this created issue I think this is good solution until the indexer get's fixed? |
I see, yes I think so. I just realized this PR should fix this issue also #3338 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small stuff
@preschian let's check that deepsrouce issue and other than that, I think let's merge this to have some previews ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
pay 50 usd |
Code Climate has analyzed commit 6dedfb8 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
looks like auto-merge doesn't care about some of the deepsource issues which jumped out again after merging main into this, it doesn't look that serious, let's catch it elsewhere |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type
What's new?
gateway
with Kodadot pinata instance on IPFS #3952Before submitting Pull Request, please make sure:
Optional
Had issue bounty label?
Community participation
Screenshot