Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chain endpoint still using the old one #4032

Merged
merged 4 commits into from
Sep 27, 2022
Merged

fix: chain endpoint still using the old one #4032

merged 4 commits into from
Sep 27, 2022

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kodabot
Copy link
Collaborator

kodabot commented Sep 27, 2022

WARNING @preschian PR for issue #3842 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #3842

@netlify
Copy link

netlify bot commented Sep 27, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 207f506
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/633342f387e8f400081d0092
😎 Deploy Preview https://deploy-preview-4032--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Sep 27, 2022

Code Climate has analyzed commit 0cbccf1 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian marked this pull request as ready for review September 27, 2022 06:21
@preschian preschian requested review from a team as code owners September 27, 2022 06:21
@preschian preschian requested review from Jarsen136 and petersopko and removed request for a team September 27, 2022 06:21
@preschian
Copy link
Member Author

how to test/reproduce the error:

  1. visit snek page https://deploy-preview-4032--koda-nuxt.netlify.app/snek/gallery/659233203-3
  2. open chrome dev tools
  3. copy session storage value to code editor under Application > Session Storage > https://deploy-preview-4032--koda-nuxt.netlify.app
  4. edit all string with wss://rococo-basilisk-rpc.hydration.dev to any error string wss://error.dev. put back edited JSON to Session Storage
  5. reload the page
  6. on the console log the API should be connected to the correct endpoint

I added a clear session also in the logout button. in case the error still occurs, try to re-login (logout button and then connect again)

@petersopko
Copy link
Contributor

how to test/reproduce the error:

this worked for me :) let's have @Jarsen136 to take a look at the code and 🚀

@petersopko petersopko added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Sep 27, 2022
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Sep 27, 2022
@yangwao
Copy link
Member

yangwao commented Sep 27, 2022

pay 150 usd

@yangwao
Copy link
Member

yangwao commented Sep 27, 2022

😍 Perfect, I’ve sent the payout
💵 $150 @ 42.94 USD/KSM ~ 3.493 $KSM
🧗 DY4SQF2iD456tH89aQtz5wv1EV3BbSW8wKKuMcwbmXaj1pM
🔗 0xee5f404314326647aae54aee4e47351e4a7f5ae00ed7c6681d317f845f89fff9

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Sep 27, 2022
@yangwao yangwao merged commit 1c18d81 into main Sep 27, 2022
@yangwao yangwao deleted the fix-api-url branch September 27, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache (weird) bug on Firefox
5 participants