Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#4043): Ability show balance in navbar dropdown #4044

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Sep 28, 2022

  • 🐍 snek is a default prefix
  • 🐛 unable to fetch balance for tokens

The issue was caused by me :) i changed the const to getter and forgot to check the implementation 😢

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screenshot 2022-09-28 at 13 38 51

@vikiival vikiival requested review from a team as code owners September 28, 2022 11:42
@vikiival vikiival requested review from kkukelka and petersopko and removed request for a team September 28, 2022 11:42
@netlify
Copy link

netlify bot commented Sep 28, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 9c22d75
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6334330d7bdb4800084bd311
😎 Deploy Preview https://deploy-preview-4044--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Sep 28, 2022

Code Climate has analyzed commit 9c22d75 and detected 0 issues on this pull request.

View more on Code Climate.

@petersopko
Copy link
Contributor

I wonder why do you still see unit instead of KSM in the screenshot you attached (checked beta/prod and it's KSM for me)

@yangwao
Copy link
Member

yangwao commented Sep 28, 2022

bsx first in selector

balance, umm

image

when I went to assets, it shows

image

@yangwao yangwao merged commit 36073f6 into main Sep 28, 2022
@yangwao yangwao deleted the supplemental-snek branch September 28, 2022 11:48
@petersopko
Copy link
Contributor

umm, this is what I'm seeing after this PR, on this deploy and on main ? (I have both KSM and BSX in different amounts)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero balance on Basilisk even showing non-zero in assets page
3 participants