Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: snackbar index order 🔢 #4051

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

kkukelka
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring
snackbar-index.mov

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kkukelka kkukelka requested review from a team as code owners September 28, 2022 18:17
@kkukelka kkukelka requested review from Jarsen136 and petersopko and removed request for a team September 28, 2022 18:17
@netlify
Copy link

netlify bot commented Sep 28, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 1b1fa00
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/633523a7b6e799000998b68c
😎 Deploy Preview https://deploy-preview-4051--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Sep 28, 2022

SUCCESS @kkukelka PR for issue #4018 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@Jarsen136
Copy link
Contributor

Jarsen136 commented Sep 29, 2022

reordered all elements in z-stack to make notifications appear on top again

👍

WFM and Code LGTM

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Sep 29, 2022
@codeclimate
Copy link

codeclimate bot commented Sep 29, 2022

Code Climate has analyzed commit 1b1fa00 and detected 0 issues on this pull request.

View more on Code Climate.

@petersopko petersopko merged commit b9c748e into kodadot:main Sep 29, 2022
@petersopko
Copy link
Contributor

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Sep 29, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 43.31 USD/KSM ~ 1.154 $KSM
🧗 EqdyzrzVmeHwMdMwvPeCMnNdbuQDbD3YrjY93xq9Ln3jUGW
🔗 0xea082c84c529af0deaca456b5d83d42b99e49262033df4a7a7848cecd554e59f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification covered by Navbar
5 participants