Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: issue_4022 #4057

Merged
merged 4 commits into from
Oct 7, 2022
Merged

feat: issue_4022 #4057

merged 4 commits into from
Oct 7, 2022

Conversation

zhengow
Copy link
Contributor

@zhengow zhengow commented Sep 30, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </movr/explore/?tab=COLLECTION&page=1>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image
    image

@zhengow zhengow requested review from a team as code owners September 30, 2022 19:51
@zhengow zhengow requested review from kkukelka and petersopko and removed request for a team September 30, 2022 19:51
@kodabot
Copy link
Collaborator

kodabot commented Sep 30, 2022

WARNING @zhengow PR for issue #4022 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4022

@netlify
Copy link

netlify bot commented Sep 30, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 46b56df
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/633fea061d6aa7000903a8ed
😎 Deploy Preview https://deploy-preview-4057--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since most of these components extend PrefixMixin already i would suggest making a new computed property in the mixin itself, something like

get isMoonriver(): boolean {
 return this.urlPrefix === 'movr'
}

and access it directly in every component without Props

@zhengow
Copy link
Contributor Author

zhengow commented Oct 7, 2022

since most of these components extend PrefixMixin already i would suggest making a new computed property in the mixin itself, something like

get isMoonriver(): boolean {
 return this.urlPrefix === 'movr'
}

and access it directly in every component without Props

done

Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet, gtg 🏆

@petersopko petersopko added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Oct 7, 2022
Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@codeclimate
Copy link

codeclimate bot commented Oct 7, 2022

Code Climate has analyzed commit 46b56df and detected 0 issues on this pull request.

View more on Code Climate.

@petersopko petersopko merged commit 9685097 into kodadot:main Oct 7, 2022
@petersopko
Copy link
Contributor

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Oct 7, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 43.38 USD/KSM ~ 1.153 $KSM
🧗 EgCzZLpVe7zg7RHh79qPyC8UrykVkA22YY2oj7sWMZf15Ws
🔗 0x2c4aa5186fdfc121ded60bc9cf66e9cf1158fb695c4e93c0a5f52f3afb58e874

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants