Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update subapi package without warnings 📦 #4060

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

kkukelka
Copy link
Member

@kkukelka kkukelka commented Oct 1, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Screenshot 2022-10-01 at 17 26 59

this also fixed transaction fees at simple mint
Screenshot 2022-10-01 at 17 17 15

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kkukelka kkukelka requested review from a team as code owners October 1, 2022 15:36
@kkukelka kkukelka requested review from prachi00 and petersopko and removed request for a team October 1, 2022 15:36
@kodabot
Copy link
Collaborator

kodabot commented Oct 1, 2022

SUCCESS @kkukelka PR for issue #4055 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 1, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 4476bf0
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/633af427fbe419000922898f
😎 Deploy Preview https://deploy-preview-4060--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kkukelka kkukelka requested a review from roiLeo October 1, 2022 15:38
@petersopko
Copy link
Contributor

built and tested without problem 👍🏻

Copy link
Contributor

@petersopko petersopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Niiiiiice! did you spend more time than expected on this task?

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Oct 3, 2022
@kkukelka
Copy link
Member Author

kkukelka commented Oct 3, 2022

✅ Niiiiiice! did you spend more time than expected on this task?

debugging the pnpm problem was quite a hassle... 😓 (going through all the dependency trees and stuff like that)
took like 2-3h to complete

@petersopko
Copy link
Contributor

as far as I can tell this is gtg, please let's just resolve conflicts (sorry, merged some packages updates prematurely) @kkukelka 🙏🏻

@kkukelka
Copy link
Member Author

kkukelka commented Oct 3, 2022

as far as I can tell this is gtg, please let's just resolve conflicts (sorry, merged some packages updates prematurely) @kkukelka 🙏🏻

done

@roiLeo
Copy link
Contributor

roiLeo commented Oct 3, 2022

I'd be in favor of increasing the bounty on this PR maybe add some bonus for the time spent

@codeclimate
Copy link

codeclimate bot commented Oct 3, 2022

Code Climate has analyzed commit 4476bf0 and detected 0 issues on this pull request.

View more on Code Climate.

@petersopko petersopko merged commit 74375e2 into kodadot:main Oct 3, 2022
@petersopko
Copy link
Contributor

pay 125 usd

@petersopko
Copy link
Contributor

pay 125 usd

@yangwao looks like hit or miss with the payouts for the past couple of days, could you check when you find time?

@yangwao
Copy link
Member

yangwao commented Oct 3, 2022

😍 Perfect, I’ve sent the payout
💵 $125 @ 42.19 USD/KSM ~ 2.963 $KSM
🧗 EqdyzrzVmeHwMdMwvPeCMnNdbuQDbD3YrjY93xq9Ln3jUGW
🔗 0x6e28f690df83a228fbeb64c0577f3c1a73c16a377911968760309a2898f352fb

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update @kodadot1/sub-api package
5 participants