Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4004 covering missing strings #4070

Merged
merged 1 commit into from
Oct 25, 2022
Merged

#4004 covering missing strings #4070

merged 1 commit into from
Oct 25, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Oct 4, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@prachi00 prachi00 requested review from a team as code owners October 4, 2022 01:55
@prachi00 prachi00 requested review from kkukelka and petersopko and removed request for a team October 4, 2022 01:55
@kodabot
Copy link
Collaborator

kodabot commented Oct 4, 2022

WARNING @prachi00 PR for issue #4004 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4004

@netlify
Copy link

netlify bot commented Oct 4, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 02dbc21
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/633b929e63907800085cb083
😎 Deploy Preview https://deploy-preview-4070--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@prachi00
Copy link
Member Author

prachi00 commented Oct 4, 2022

I'll keep updating this PR with more missing strings

@codeclimate
Copy link

codeclimate bot commented Oct 4, 2022

Code Climate has analyzed commit 02dbc21 and detected 0 issues on this pull request.

View more on Code Climate.

@petersopko
Copy link
Contributor

I'll keep updating this PR with more missing strings

Maybe you know this, maybe you don't but I found pretty good plugin which helps identify / scan the codebase for hardcoded strings or possible missed translations:

@petersopko
Copy link
Contributor

just a note: we should probably reopen most of the translations once this get done properly

@yangwao
Copy link
Member

yangwao commented Oct 25, 2022

pay 30 usd

@yangwao yangwao merged commit ba1c966 into main Oct 25, 2022
@yangwao yangwao deleted the feat-trans-leftover branch October 25, 2022 09:39
@yangwao
Copy link
Member

yangwao commented Oct 25, 2022

😍 Perfect, I’ve sent the payout
💵 $30 @ 34.35 USD/KSM ~ 0.873 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x3be9c118fbee811f9c8ebb4357595686a1bcb64ec1d75774f25a8e8410468b29

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Covering the missing strings
4 participants