Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redirect to incorrect place after click on collection on navbar #4134

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested review from a team as code owners October 18, 2022 16:06
@Jarsen136 Jarsen136 requested review from roiLeo and petersopko and removed request for a team October 18, 2022 16:06
@kodabot
Copy link
Collaborator

kodabot commented Oct 18, 2022

SUCCESS @Jarsen136 PR for issue #4133 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 09e7608
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/634fcf7a73e4750008e0ecb9
😎 Deploy Preview https://deploy-preview-4134--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☑️ code lgtm

@roiLeo roiLeo enabled auto-merge October 18, 2022 16:53
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 19, 2022
@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

pay 30

Copy link
Member

@yangwao yangwao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

pay 30

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

pay 30 usd

@codeclimate
Copy link

codeclimate bot commented Oct 19, 2022

Code Climate has analyzed commit 09e7608 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

pay 30 usd

seems webhooks or something is slowing down bot 👀

@Jarsen136
Copy link
Contributor Author

pay 30 usd

seems webhooks or something is slowing down bot 👀

Hey, I did not put the payment link there. It's a small fix.

@roiLeo roiLeo merged commit acec63e into kodadot:main Oct 19, 2022
@Jarsen136
Copy link
Contributor Author

By the way, could you pls check this issue? @yangwao
#4048 (comment)

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

Hey, I did not put the payment link there. It's a small fix.

lmao, I'm going too fast ;D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect to incorrect place after click on collection on navbar
4 participants