fix: incorrect currency displayed in profiledropdown #4135

Jarsen136 · 2022-10-18T16:17:01Z

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

Bugfix
Feature
Refactoring

What's new?

PR closes Correct currency displayed in profiledropdown #4056
Requires deployment <rubick/magick_issue>
<brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality
I've posted a screenshot of demonstrated change in this PR

Optional

I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
I've tested PR on mobile and everything seems works
I found edge cases
I've written some unit tests 🧪

Had issue bounty label?

Fill up your KSM address: Payout

Community participation

Are you at KodaDot Discord?

Screenshot

BSX:

My fix has changed something on UI; a screenshot is best to understand changes for others.

kodabot · 2022-10-18T16:17:05Z

SUCCESS @Jarsen136 PR for issue #4056 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

netlify · 2022-10-18T16:17:05Z

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	`974b41d`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/6352a5bf70f4fa00083e8e8a
😎 Deploy Preview	https://deploy-preview-4135--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

roiLeo

wfm

could you check why tests are failing?

vikiival

PLease DRY

vikiival · 2022-10-19T10:21:54Z

components/rmrk/Gallery/CollectionDetail.vue

            {{ $t('Floor') }} :
+            <TokenMoney
+              v-if="tokenId"
+              :value="collectionFloorPrice"
+              :token-id="tokenId"
+              :prefix="urlPrefix"
+              inline />
            <Money
+              v-else
              :value="collectionFloorPrice"
              inline
              data-cy="collection-floor-price" />


Unify under one component (check AccountBalance.vue)

Ok, I made a CommonTokenMoney Component.

vikiival · 2022-10-19T10:23:02Z

utils/mixins/prefixMixin.ts

@@ -18,4 +19,8 @@ export default class PrefixMixin extends Vue {
  get isMoonriver(): boolean {
    return this.urlPrefix === 'movr'
  }
+
+  get tokenId() {
+    return getKusamaAssetId(this.urlPrefix)


getKusamaAssetId should handle also other chains

For now, the CommonTokenMoney could handle both rmrk\bsx\snek chains. What else chain should I add? 👀

in the future there will be movr/glmr and astar

Yup, but I'm not sure which token should be used in these chains.

I guess the asset list query should also add more tokens in the future. Or if I have miss something?

return zero for now please

or better we can define that in the chain config :)

OK, I will check.

vikiival · 2022-10-20T10:32:01Z

components/shared/CommonTokenMoney.vue

@@ -0,0 +1,26 @@
+<template>
+  <TokenMoney
+    v-if="tokenId"


tokenId isnt prop?

tokenId is from PrefixMixin rather than the props

tokenId is props now

…sue-4056

yangwao · 2022-10-21T10:16:32Z

hmm, I guess it's not possible to have bsx on rmrk :)

codeclimate · 2022-10-21T14:00:06Z

Code Climate has analyzed commit 974b41d and detected 0 issues on this pull request.

View more on Code Climate.

Jarsen136 · 2022-10-21T14:08:08Z

hmm, I guess it's not possible to have bsx on rmrk :)

Good catch! Gallery items from different chains may display on the Newest list at the same time.

✅ FIXED

yangwao · 2022-10-21T15:39:38Z

1.0000 KSM ? Like should be 1 KSM I guess?

Jarsen136 · 2022-10-23T09:57:06Z

1.0000 KSM ? Like should be 1 KSM I guess?

on bsx:

on rmrk:

It seem related to #3868

yangwao · 2022-10-24T09:09:02Z

hmm so till then I guess we can merge it?

yangwao · 2022-10-24T12:12:25Z

let's see

pay 50

yangwao · 2022-10-24T12:12:37Z

😍 Perfect, I’ve sent the payout
💵 $50 @ 34.44 USD/KSM ~ 1.452 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x0cddd54ad5108d54817ded1dd3fa96ce06ed92713e5b3b45f65b223aac85221e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

fix: incorrect currency displayed in profiledropdown

ce88a39

Jarsen136 requested review from a team as code owners October 18, 2022 16:17

Jarsen136 requested review from roiLeo and petersopko and removed request for a team October 18, 2022 16:17

roiLeo reviewed Oct 19, 2022

View reviewed changes

yangwao assigned vikiival Oct 19, 2022

vikiival requested changes Oct 19, 2022

View reviewed changes

vikiival reviewed Oct 19, 2022

View reviewed changes

feat: CommonTokenMoney component for more chain

fc728a0

Jarsen136 marked this pull request as draft October 19, 2022 16:13

Merge branch 'main' into issue-4056

896ce56

Jarsen136 marked this pull request as ready for review October 20, 2022 01:12

Jarsen136 requested review from roiLeo and vikiival October 20, 2022 01:17

Merge branch 'main' into issue-4056

76a9451

vikiival requested changes Oct 20, 2022

View reviewed changes

Jarsen136 added 3 commits October 20, 2022 22:11

fix: set default token id for new chain

eddf54e

Merge branch 'issue-4056' of github.com:Jarsen136/nft-gallery into is…

6f982bb

…sue-4056

fix: add default value for switch

a6fa9de

yangwao removed the request for review from petersopko October 21, 2022 09:21

fix: token money at different chain

974b41d

yangwao added the paid pull-request has been paid label Oct 24, 2022

yangwao merged commit 9ada62b into kodadot:main Oct 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: incorrect currency displayed in profiledropdown #4135

fix: incorrect currency displayed in profiledropdown #4135

Jarsen136 commented Oct 18, 2022

kodabot commented Oct 18, 2022

netlify bot commented Oct 18, 2022 •

edited

roiLeo left a comment

vikiival left a comment

vikiival Oct 19, 2022

Jarsen136 Oct 20, 2022

vikiival Oct 19, 2022

Jarsen136 Oct 20, 2022

yangwao Oct 20, 2022

Jarsen136 Oct 20, 2022

vikiival Oct 20, 2022

vikiival Oct 20, 2022

Jarsen136 Oct 20, 2022

vikiival Oct 20, 2022

Jarsen136 Oct 20, 2022

Jarsen136 Oct 21, 2022

yangwao commented Oct 21, 2022

codeclimate bot commented Oct 21, 2022

Jarsen136 commented Oct 21, 2022

yangwao commented Oct 21, 2022

Jarsen136 commented Oct 23, 2022

yangwao commented Oct 24, 2022

yangwao commented Oct 24, 2022

yangwao commented Oct 24, 2022

fix: incorrect currency displayed in profiledropdown #4135

fix: incorrect currency displayed in profiledropdown #4135

Conversation

Jarsen136 commented Oct 18, 2022

PR type

What's new?

Before submitting Pull Request, please make sure:

Optional

Had issue bounty label?

Community participation

Screenshot

kodabot commented Oct 18, 2022

netlify bot commented Oct 18, 2022 • edited

✅ Deploy Preview for koda-nuxt ready!

roiLeo left a comment

Choose a reason for hiding this comment

vikiival left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yangwao commented Oct 21, 2022

codeclimate bot commented Oct 21, 2022

Jarsen136 commented Oct 21, 2022

yangwao commented Oct 21, 2022

Jarsen136 commented Oct 23, 2022

yangwao commented Oct 24, 2022

yangwao commented Oct 24, 2022

yangwao commented Oct 24, 2022

netlify bot commented Oct 18, 2022 •

edited