Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not buy due to multi asset #4137

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Conversation

KngZhi
Copy link
Contributor

@KngZhi KngZhi commented Oct 19, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@KngZhi KngZhi requested review from a team as code owners October 19, 2022 01:20
@KngZhi KngZhi requested review from roiLeo and petersopko and removed request for a team October 19, 2022 01:20
@kodabot
Copy link
Collaborator

kodabot commented Oct 19, 2022

WARNING @KngZhi PR for issue #4122 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4122

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit e78ea7a
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/634f516a955234000906d8b6
😎 Deploy Preview https://deploy-preview-4137--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Oct 19, 2022

Code Climate has analyzed commit e78ea7a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm
but i'm concerned that I see this part of code used in various places (CreateCollection, AvailableActions, Teleport, Transfer etc..)

get balance(): string {
  return this.$store.getters.getAuthBalance
}

shouldn't we change it too?

@vikiival
Copy link
Member

vikiival commented Oct 19, 2022

Fix is OK

but i'm concerned that I see this part of code used in various places (CreateCollection, AvailableActions, Teleport, Transfer etc..)

But this part of code is used for KSM on RMRK :), changing that on various places will break the app

@yangwao yangwao mentioned this pull request Oct 19, 2022
@yangwao yangwao merged commit 5cad991 into kodadot:main Oct 19, 2022
@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

pay 50

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 37.62 USD/KSM ~ 1.329 $KSM
🧗 DaWoVNNhBTdqJ5iPN3UcaLeamkPpJeGWdrs8LhvX9TQbadc
🔗 0xcf84f2237981ce44ac1ffa8dc791136fce6f0ed3f7428c1ad4dc91f92a8f4123

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buying and Make Offer is disabled for insufficient balance
5 participants