Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mobile landing on new neobrutalism design #4148

Merged
merged 1 commit into from
Oct 19, 2022
Merged

fix: Mobile landing on new neobrutalism design #4148

merged 1 commit into from
Oct 19, 2022

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Oct 19, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Kapture 2022-10-19 at 22 53 28

@Jarsen136 Jarsen136 requested review from a team as code owners October 19, 2022 14:52
@Jarsen136 Jarsen136 requested review from roiLeo and petersopko and removed request for a team October 19, 2022 14:52
@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 65af22f
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63500f2e359f200008e5b8f2
😎 Deploy Preview https://deploy-preview-4148--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Oct 19, 2022

SUCCESS @Jarsen136 PR for issue #4146 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@codeclimate
Copy link

codeclimate bot commented Oct 19, 2022

Code Climate has analyzed commit 65af22f and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • got trouble to connect wallet on mobile
  • same things for changing language or theme
  • I find the buttons in the footer a bit too close for my hand

@Jarsen136
Copy link
Contributor Author

  • got trouble to connect wallet on mobile
  • same things for changing language or theme
  • I find the buttons in the footer a bit too close for my hand

Hey, this PR is to close ##4146, related to the viewport when scrolling. 👀

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

  • I find the buttons in the footer a bit too close for my hand

fwded to #4125

@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

pay 50 usd

@yangwao yangwao merged commit e798098 into main Oct 19, 2022
@yangwao yangwao deleted the issue-4146 branch October 19, 2022 15:35
@yangwao
Copy link
Member

yangwao commented Oct 19, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 38.01 USD/KSM ~ 1.315 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xa3cf77f8fb013d271fd287612bd19021d0c36442deb9e8dff18f70e035e26544

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile landing on new neobrutalism design
4 participants