Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4161 fixes with drawer, colors // connect wallet on mobile #4162

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Oct 22, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2022-10-21 at 7 01 13 PM

@prachi00 prachi00 requested a review from a team as a code owner October 22, 2022 02:00
@prachi00 prachi00 requested review from Jarsen136 and removed request for a team October 22, 2022 02:00
@netlify
Copy link

netlify bot commented Oct 22, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 0b09382
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63534ed29aa0b4000aa8f3ea
😎 Deploy Preview https://deploy-preview-4162--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Oct 22, 2022

SUCCESS @prachi00 PR for issue #4161 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@codeclimate
Copy link

codeclimate bot commented Oct 22, 2022

Code Climate has analyzed commit 0b09382 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 22, 2022
@prachi00
Copy link
Member Author

Also, whooever is doing the payout for this one, please don't, payout was done twice on #4131 and it would be cool to adjust it here
@yangwao

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran 2022-10-24 à 8 27 16 AM

There are still some issues with wallet, if you would like to take a look ref #4144

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe wrong background?
Capture d’écran 2022-10-24 à 8 36 00 AM

Please could you update description as I don't really know what's changing here

@yangwao yangwao changed the title #4161 fixes with drawer, colors #4161 fixes with drawer, colors // connect wallet on mobile Oct 24, 2022
@yangwao
Copy link
Member

yangwao commented Oct 24, 2022

with lot of accounts on iphone 12 pro does this

image

Let's fix it in #4144

@yangwao yangwao merged commit 40abbda into main Oct 24, 2022
@yangwao yangwao deleted the feat-mobile-wallet branch October 24, 2022 10:11
@exezbcz
Copy link
Member

exezbcz commented Oct 24, 2022

Few adjustments.

Visual:

  • popup doesn't have a stroke.
  • hover effect on each wallet should be different, not k-accent but in light mode: k-accentlight2 and in darkmode k-accentlight2dark, both are in landing page handoff - first page - colors
  • "connect wallet" section should have the same height as the wallet selection (polkadot.js etc.)

Functional:

  • by default, it should feature other wallet options, like in the Figma
    image

@prachi00
Copy link
Member Author

Few adjustments.

Visual:

  • popup doesn't have a stroke.
  • hover effect on each wallet should be different, not k-accent but in light mode: k-accentlight2 and in darkmode k-accentlight2dark, both are in landing page handoff - first page - colors
  • "connect wallet" section should have the same height as the wallet selection (polkadot.js etc.)

Functional:

  • by default, it should feature other wallet options, like in the Figma
    image

I'll add these in #4144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect wallet on mobile
6 participants