Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make event passive to fix sluggish vertical scroll #4163

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

kkukelka
Copy link
Member

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • PR closes Landing page issue on scroll #4160
  • Requires deployment <rubick/magick_issue>
  • Fixed an issue that prevented users from scrolling smoothly over Carousels on Firefox

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@kkukelka kkukelka requested a review from a team as a code owner October 22, 2022 10:18
@kkukelka kkukelka requested review from Jarsen136 and removed request for a team October 22, 2022 10:18
@kodabot
Copy link
Collaborator

kodabot commented Oct 22, 2022

SUCCESS @kkukelka PR for issue #4160 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 22, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f62b458
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6353c37f93b22f0009f8a482
😎 Deploy Preview https://deploy-preview-4163--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Oct 22, 2022

Code Climate has analyzed commit f62b458 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 requested a review from roiLeo October 22, 2022 10:20
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Top! wfm

@roiLeo
Copy link
Contributor

roiLeo commented Oct 24, 2022

pay 20

@roiLeo roiLeo merged commit 367472d into kodadot:main Oct 24, 2022
@yangwao
Copy link
Member

yangwao commented Oct 24, 2022

😍 Perfect, I’ve sent the payout
💵 $20 @ 34.22 USD/KSM ~ 0.584 $KSM
🧗 EqdyzrzVmeHwMdMwvPeCMnNdbuQDbD3YrjY93xq9Ln3jUGW
🔗 0xf48536a5a074378fa5bdc63286a6fc1307f04c768f50fcf521e3b1c1370119fd

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Landing page issue on scroll
5 participants