Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: setup histoire and workspaces #4167

Merged
merged 16 commits into from
Oct 29, 2022

Conversation

preschian
Copy link
Member

@preschian preschian commented Oct 24, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

  • at first bd3127f, I want to move our nuxt app under the folder. but, to minimize the changes and we don't need turborepo right now. I decided to setup workspaces and histoire only. so, we can start to using it for new redesign page
  • setup pnpm workspaces
  • setup histoire
  • please put newer component under @kodadot/ui
  • a little example in components/landing/FeaturedArticles.vue

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 0ca9a21
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/635cc2ee46f588000b42463a
😎 Deploy Preview https://deploy-preview-4167--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@preschian preschian changed the title feat: setup histoire and workspaces refactor: setup histoire and workspaces Oct 24, 2022
@vikiival
Copy link
Member

Looking forward

@preschian preschian marked this pull request as ready for review October 24, 2022 13:23
@preschian preschian requested a review from a team as a code owner October 24, 2022 13:23
@preschian preschian requested review from Jarsen136, vikiival, roiLeo and yangwao and removed request for a team October 24, 2022 13:23
package.json Outdated Show resolved Hide resolved
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smol stuff

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!
Capture d’écran 2022-10-24 à 4 09 22 PM

  • it miss to link somewhere histoire doc
  • should we had lorem ipsum instead of actual content?
  • can we handle Light/Dark mode variant globally? how is it going to work with multiple buttons variant?

@preschian
Copy link
Member Author

preschian commented Oct 24, 2022

  • it miss to link somewhere histoire doc
  • should we had lorem ipsum instead of actual content?

aahh yes, this is important. I forgot to add histoire doc link in the readme

  • can we handle Light/Dark mode variant globally? how is it going to work with multiple buttons variant?

need to find a workaround for light/dark mode globally. let me check the docs first

update: oohh, yes they already provide the dark mode class https://histoire.dev/reference/config.html#sandboxdarkclass. should be using that

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I look forward to working with histoire

@vikiival
Copy link
Member

@preschian we were talking with @yangwao to rename the library to @kodadot/brick

  • because we are making building blocks
  • and should evoke the neobrutalism style
    • it is easy to pronounce

also maybe one thing: on npm we have org @kodadot1

@preschian
Copy link
Member Author

@preschian we were talking with @yangwao to rename the library to @kodadot/brick

  • because we are making building blocks
  • and should evoke the neobrutalism style
    • it is easy to pronounce

also maybe one thing: on npm we have org @kodadot1

noted, will rename it 👍

@yangwao
Copy link
Member

yangwao commented Oct 28, 2022

conflicts 😬 @preschian

@codeclimate
Copy link

codeclimate bot commented Oct 29, 2022

Code Climate has analyzed commit 0ca9a21 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao yangwao merged commit b18abfd into kodadot:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants