Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 landing mobile version #4168

Merged
merged 7 commits into from
Oct 25, 2022
Merged

🔧 landing mobile version #4168

merged 7 commits into from
Oct 25, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 24, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot

iPhone11
Capture d’écran 2022-10-24 à 15 06 16

@roiLeo roiLeo requested a review from a team as a code owner October 24, 2022 13:08
@roiLeo roiLeo requested review from Jarsen136 and removed request for a team October 24, 2022 13:08
@netlify
Copy link

netlify bot commented Oct 24, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit ad402e1
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6357b026975308000848ccfc
😎 Deploy Preview https://deploy-preview-4168--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@roiLeo roiLeo marked this pull request as draft October 24, 2022 13:14
@roiLeo roiLeo marked this pull request as ready for review October 24, 2022 13:19
@Jarsen136
Copy link
Contributor

Nice CSS refactor. pls also take a look at the landing page on the PC
image

image

roiLeo
roiLeo commented Oct 24, 2022
View reviewed changes
Copy link
Contributor Author

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of importing Search component from @/components/search/Search.vue I would prefer to include only the needed SearchBarInput

@Jarsen136
Copy link
Contributor

The margin between search bar and chains list is still too long.
image

@codeclimate
Copy link

codeclimate bot commented Oct 25, 2022

Code Climate has analyzed commit ad402e1 and detected 0 issues on this pull request.

View more on Code Climate.

Jarsen136
Jarsen136 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Oct 25, 2022
@yangwao yangwao merged commit 8572206 into kodadot:main Oct 25, 2022
@roiLeo roiLeo deleted the fix/landing/SearchComponent branch October 25, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
A-mobile css S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How looks new design on phone
3 participants
@roiLeo @Jarsen136 @yangwao