Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing browser history on search #4202

Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix: Missing browser history on search #4202

merged 1 commit into from
Oct 28, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Kapture 2022-10-28 at 22 30 04

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 28, 2022 14:30
@Jarsen136 Jarsen136 requested review from prachi00 and removed request for a team October 28, 2022 14:30
@kodabot
Copy link
Collaborator

kodabot commented Oct 28, 2022

SUCCESS @Jarsen136 PR for issue #4194 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 28, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 7accc21
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/635be79dbe44ab00098c7778
😎 Deploy Preview https://deploy-preview-4202--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Oct 28, 2022

Code Climate has analyzed commit 7accc21 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Oct 28, 2022

nice wfm

pay 30 usd

@yangwao yangwao merged commit 0c16e8e into main Oct 28, 2022
@yangwao yangwao deleted the issue-4194 branch October 28, 2022 14:52
@yangwao
Copy link
Member

yangwao commented Oct 28, 2022

😍 Perfect, I’ve sent the payout
💵 $30 @ 35.38 USD/KSM ~ 0.848 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x20b7ba13821164a7e8f9dae0e01e7d64c186a68483062dc65ea870765c07d89e

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing browser history on search?
3 participants