Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 History component Amount token #4209

Merged
merged 2 commits into from
Nov 1, 2022
Merged

🔧 History component Amount token #4209

merged 2 commits into from
Nov 1, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 31, 2022

PR type

  • Bugfix

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot

Screenshot 2022-10-31 at 09-42-10 KOSMOS 2VC KodaDot - Kusama NFT Market Explorer
Screenshot 2022-10-28 at 11-54-35 MAGENTA KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner October 31, 2022 08:46
@roiLeo roiLeo requested review from prachi00 and removed request for a team October 31, 2022 08:47
@codeclimate
Copy link

codeclimate bot commented Oct 31, 2022

Code Climate has analyzed commit c095e3c and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Oct 31, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit c095e3c
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/635f8b85621ff100084fabd6
😎 Deploy Preview https://deploy-preview-4209--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao yangwao added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Nov 1, 2022
@yangwao
Copy link
Member

yangwao commented Nov 1, 2022

lgtm

@yangwao yangwao merged commit b7e43e3 into kodadot:main Nov 1, 2022
@yangwao yangwao mentioned this pull request Nov 1, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prachi00 prachi00 prachi00 approved these changes

Assignees
No one assigned
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nft History component wrong currency
3 participants
@roiLeo @yangwao @prachi00