Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Redesign scroll up button #4212

Merged
merged 4 commits into from
Nov 1, 2022
Merged

feat: Redesign scroll up button #4212

merged 4 commits into from
Nov 1, 2022

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Oct 31, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 31, 2022 12:17
@Jarsen136 Jarsen136 requested review from roiLeo and removed request for a team October 31, 2022 12:17
@kodabot
Copy link
Collaborator

kodabot commented Oct 31, 2022

SUCCESS @Jarsen136 PR for issue #4204 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit b1fc8df
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63612c0950001b000842119e
😎 Deploy Preview https://deploy-preview-4212--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ lgtm

To go further:

  • this component can bo written with histoire & Nuxt3 way
  • is it normal that we don't have the same hover state as footer button?

@Jarsen136
Copy link
Contributor Author

  • is it normal that we don't have the same hover state as footer button?

✅ FIXED

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Oct 31, 2022
@yangwao
Copy link
Member

yangwao commented Nov 1, 2022

pay 50
love it

@yangwao
Copy link
Member

yangwao commented Nov 1, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 34.14 USD/KSM ~ 1.465 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0x58f705967b5bd278891c5673dc508112f90c07d4c95f120e8369cc226f4ecd26

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 1, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 1, 2022

Code Climate has analyzed commit b1fc8df and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao yangwao disabled auto-merge November 1, 2022 14:25
@yangwao yangwao merged commit 8a4edc0 into kodadot:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesign scroll up button
4 participants