Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4219 footer overflow fix #4223

Merged
merged 1 commit into from
Nov 2, 2022
Merged

#4219 footer overflow fix #4223

merged 1 commit into from
Nov 2, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Nov 2, 2022

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.

PR type

  • Bugfix
  • Feature
  • Refactoring

What's new?

Before submitting Pull Request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
  • I've tested PR on mobile and everything seems works
  • I found edge cases
  • I've written some unit tests 🧪

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Screen Shot 2022-11-01 at 7 02 15 PM

@prachi00 prachi00 requested a review from a team as a code owner November 2, 2022 02:02
@prachi00 prachi00 requested review from preschian and removed request for a team November 2, 2022 02:02
@netlify
Copy link

netlify bot commented Nov 2, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit be82602
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6361cfcaae5ad20008c14e6f
😎 Deploy Preview https://deploy-preview-4223--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Nov 2, 2022

SUCCESS @prachi00 PR for issue #4219 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@codeclimate
Copy link

codeclimate bot commented Nov 2, 2022

Code Climate has analyzed commit be82602 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Nov 2, 2022
@yangwao
Copy link
Member

yangwao commented Nov 2, 2022

pay 20 usd

@yangwao yangwao merged commit ab29d6b into main Nov 2, 2022
@yangwao yangwao deleted the feat-footer-overlap branch November 2, 2022 14:03
@yangwao
Copy link
Member

yangwao commented Nov 2, 2022

😍 Perfect, I’ve sent the payout
💵 $20 @ 32.69 USD/KSM ~ 0.612 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0xae514cf77d6b58455f0bcf91ed54232eec1ad53a79582272ee16e513764a2014

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe in footer overflows on tablet width
4 participants