Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4241 Navbar scroll update #4243

Merged
merged 5 commits into from
Nov 5, 2022
Merged

#4241 Navbar scroll update #4243

merged 5 commits into from
Nov 5, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Nov 3, 2022 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

PR Context?

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2022-11-02 at 7 24 06 PM

@prachi00 prachi00 requested a review from a team as a code owner November 3, 2022 02:25
@prachi00 prachi00 requested review from preschian and removed request for a team November 3, 2022 02:25
@netlify
Copy link

netlify bot commented Nov 3, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit b35bf2b
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6365b85353f7e400094b99d9
😎 Deploy Preview https://deploy-preview-4243--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Nov 3, 2022

SUCCESS @prachi00 PR for issue #4241 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@prachi00
Copy link
Member Author

prachi00 commented Nov 3, 2022

@exezbcz let me know if this is what you expected

@preschian preschian added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Nov 3, 2022
@exezbcz
Copy link
Member

exezbcz commented Nov 3, 2022

image
yup, the bg is correct.

  • there are just some info missing
  • search bar should not expand to the rest of the nav
  • similar like this:
    image

@preschian preschian removed S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Nov 3, 2022
@preschian preschian self-requested a review November 3, 2022 09:42
@prachi00
Copy link
Member Author

prachi00 commented Nov 3, 2022

image yup, the bg is correct.

  • there are just some info missing
  • search bar should not expand to the rest of the nav
  • similar like this:
    image

so would it also show all the other info like explore, create, stats, connect button?

@exezbcz
Copy link
Member

exezbcz commented Nov 3, 2022

Yup

@prachi00
Copy link
Member Author

prachi00 commented Nov 3, 2022

image yup, the bg is correct.

  • there are just some info missing
  • search bar should not expand to the rest of the nav
  • similar like this:
    image

done

preschian
preschian requested changes Nov 4, 2022
View reviewed changes
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing searchbar on scroll?

image

@yangwao
Copy link
Member

yangwao commented Nov 4, 2022 •
edited

missing searchbar on scroll?

yes, it's missing @prachi00

it's missing on

@yangwao yangwao added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Nov 4, 2022
@prachi00
Copy link
Member Author

prachi00 commented Nov 5, 2022

Added the searchbar

@codeclimate
Copy link

codeclimate bot commented Nov 5, 2022

Code Climate has analyzed commit b35bf2b and detected 0 issues on this pull request.

View more on Code Climate.

@prachi00 prachi00 mentioned this pull request Nov 5, 2022
Merged
17 tasks
@yangwao
Copy link
Member

yangwao commented Nov 5, 2022

pay 40

@yangwao
Copy link
Member

yangwao commented Nov 5, 2022

😍 Perfect, I’ve sent the payout
💵 $40 @ 37.42 USD/KSM ~ 1.069 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x88121febc076931f2f660c3575a2b57f5f78c383b7c572fb811ecf121d056920

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 5, 2022
@yangwao yangwao disabled auto-merge November 5, 2022 11:13
@yangwao
Copy link
Member

yangwao commented Nov 5, 2022 •
edited

time to resolve conflicts @prachi00 👀

image

@yangwao yangwao merged commit 403cda8 into main Nov 5, 2022
@yangwao yangwao deleted the feat-navbar-updates branch November 5, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian requested changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign: Navbar on scroll updates
5 participants
@prachi00 @kodabot @exezbcz @yangwao @preschian