Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 display congrats on bsx after create #4250

Merged
merged 2 commits into from
Nov 4, 2022
Merged

🔧 display congrats on bsx after create #4250

merged 2 commits into from
Nov 4, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Nov 4, 2022 •
edited

PR Type

  • Bugfix

PR Context?

  • fix Congrats message that wasn't displaying on bsx/snek chain
  • fix Sharing text

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot 📸

Screenshot 2022-11-04 at 11-43-38 KodaDot - Kusama NFT Market Explorer

Screenshot 2022-11-04 at 11-32-59 KodaDot - Kusama NFT Market Explorer

might need to rework this message design
ping 🖼️ @exezbcz

@roiLeo roiLeo requested a review from a team as a code owner November 4, 2022 10:36
@roiLeo roiLeo requested review from preschian and removed request for a team November 4, 2022 10:36
@netlify
Copy link

netlify bot commented Nov 4, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit d76d961
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6364ecd90f5f650008ebcf04
😎 Deploy Preview https://deploy-preview-4250--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Nov 4, 2022

Code Climate has analyzed commit d76d961 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Nov 4, 2022

might need to rework this message design ping 🖼️ @exezbcz

Yes I was thinking same!

@yangwao yangwao mentioned this pull request Nov 4, 2022
Closed
@yangwao yangwao merged commit 997f55e into kodadot:main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roiLeo @yangwao