Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ new gallery item design #4285

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Nov 8, 2022

Tested on /bsx/gallery/945672150-19?redesign=true

PR Type

  • Feature

Context

Screenshot 📸

Screenshot 2022-11-08 at 14-37-49 KodaDot - Kusama NFT Market Explorer

@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 80e4776
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/636ccde24291d000091cd3a5
😎 Deploy Preview https://deploy-preview-4285--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

import { sanitizeIpfsUrl } from '@/components/rmrk/utils'
import type { NFT, NFTMetadata } from '@/components/rmrk/service/scheme'

export const useGalleryItem = () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function useGalleryItem has 48 lines of code (exceeds 25 allowed). Consider refactoring.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeclimate
Copy link

codeclimate bot commented Nov 10, 2022

Code Climate has analyzed commit 80e4776 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@roiLeo roiLeo marked this pull request as ready for review November 10, 2022 10:10
@roiLeo roiLeo requested a review from a team as a code owner November 10, 2022 10:10
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go~

@roiLeo roiLeo changed the title ✨ wip: new gallery item design ✨ new gallery item design Nov 10, 2022
@yangwao yangwao merged commit 83c656e into kodadot:main Nov 10, 2022
@roiLeo roiLeo deleted the feature/GalleryItem/redesign branch November 14, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants