Fix gallery skeleton #4301
Fix gallery skeleton #4301
Conversation
|
SUCCESS @nevermin9 PR for issue #4268 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-nuxt ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
hi @nevermin9 I'm still getting the same result
the expected result should be similar with collection tabs. I guess it's related with this line https://github.com/kodadot/nft-gallery/blob/main/components/rmrk/Gallery/Gallery.vue#L40-L50. could you check is it possible to use one component instead? maybe something like this <PreviewMediaResolver :src="nft.image || nft.animation_url" another-props="props" />
|
Hey, @preschian , |
hi @nevermin9, actually I still face the same result btw |
tests/cypress/e2e/basicE2E.cy.ts
Outdated
| @@ -101,11 +103,13 @@ describe('snekCollectionItem', () => { | |||
| }) | |||
|
|
|||
| describe('snekGalleryItem', () => { | |||
| it('galleryListedItemActions', () => { | |||
There was a problem hiding this comment.
seems like snek already up, we can revert this changes and merged once this PR merged #4326
|
Code Climate has analyzed commit aa90480 and detected 0 issues on this pull request. View more on Code Climate. |
preschian
added
the
S-works-for-me-✅
|
pay 30 |
|
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Better to check in slow 3G, it is hard to show)
Optional
Had issue bounty label?
Community participation
Screenshot 📸