Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4117 New hover card for user profile #4319

Merged
merged 10 commits into from
Nov 16, 2022
Merged

#4117 New hover card for user profile #4319

merged 10 commits into from
Nov 16, 2022

Conversation

prachi00
Copy link
Member

@prachi00 prachi00 commented Nov 13, 2022 •
edited

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address:
    Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2022-11-12 at 6 56 36 PM
    Screen Shot 2022-11-12 at 7 12 38 PM

@prachi00 prachi00 requested a review from a team as a code owner November 13, 2022 03:14
@prachi00 prachi00 requested review from kkukelka and removed request for a team November 13, 2022 03:14
@kodabot
Copy link
Collaborator

kodabot commented Nov 13, 2022

WARNING @prachi00 PR for issue #4117 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #4117

@netlify
Copy link

netlify bot commented Nov 13, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit d7368b9
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63744616c6c72c0009bce214
😎 Deploy Preview https://deploy-preview-4319--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Nov 16, 2022

Code Climate has analyzed commit d7368b9 and detected 0 issues on this pull request.

View more on Code Climate.

kkukelka
kkukelka approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@kkukelka kkukelka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but one question

components/identity/module/IdentityPopoverFooter.vue
:id="nft.id"
hide-name
:metadata="nft.metadata"
:data-cy="soldItems.indexOf(nft)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this data-cy used in any test?

@kkukelka kkukelka added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Nov 16, 2022
@yangwao
Copy link
Member

yangwao commented Nov 16, 2022

pay 100 usd

great, wfm

@yangwao yangwao merged commit 41ae613 into main Nov 16, 2022
@yangwao yangwao deleted the feat-hover-card branch November 16, 2022 13:03
@yangwao
Copy link
Member

yangwao commented Nov 16, 2022

😍 Perfect, I’ve sent the payout
💵 $100 @ 24.83 USD/KSM ~ 4.027 $KSM
🧗 EzGc4s9PgCPx1YnF3fqzhLzVHpHMTL4LWPScwpDrR8JKgSU
🔗 0x8f2641aa3cf5e5c68600ef4c9b3656666104a95c0990641383f53296869d5fd6

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkukelka kkukelka kkukelka approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New hover card
4 participants
@prachi00 @kodabot @yangwao @kkukelka