Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump vue@2 and pin vue-audio-visual version #4321

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Nov 13, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • fix vue-audio-visual crash by updating vue@2 to the latest version

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

image

@netlify
Copy link

netlify bot commented Nov 13, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit fdf83f1
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63706e4f9589b10008e3f6fe
😎 Deploy Preview https://deploy-preview-4321--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Nov 13, 2022

Code Climate has analyzed commit fdf83f1 and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian changed the title fix: bump vue@2 and lock vue-audio-visual fix: bump vue@2 and pin vue-audio-visual version Nov 13, 2022
@yangwao
Copy link
Member

yangwao commented Nov 13, 2022

Can we merge this?

@preschian preschian marked this pull request as ready for review November 13, 2022 15:20
@preschian preschian requested a review from a team as a code owner November 13, 2022 15:20
@preschian preschian requested review from Jarsen136 and removed request for a team November 13, 2022 15:20
@preschian
Copy link
Member Author

preschian commented Nov 13, 2022

Can we merge this?

oops, sorry forgot to mark it as ready. updated

@yangwao yangwao merged commit f846a58 into main Nov 14, 2022
@yangwao yangwao deleted the fix-audio-visual branch November 14, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants