Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 navbar dropdown #4335

Merged
merged 1 commit into from
Nov 16, 2022
Merged

🔧 navbar dropdown #4335

merged 1 commit into from
Nov 16, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Nov 16, 2022

pretty bad semantic ☹️

PR Type

  • Bugfix
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot 📸

Screenshot 2022-11-16 at 09-05-05 KodaDot - Kusama NFT Market Explorer
Capture d’écran 2022-11-16 à 9 05 56 AM

@roiLeo roiLeo requested a review from a team as a code owner November 16, 2022 08:16
@roiLeo roiLeo requested review from Jarsen136 and removed request for a team November 16, 2022 08:16
@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 60e45e5
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/63749c591a91ce000c40481e
😎 Deploy Preview https://deploy-preview-4335--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Nov 16, 2022

Code Climate has analyzed commit 60e45e5 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Nov 16, 2022

It's supplemental pr or replacing #4318 ?

@roiLeo
Copy link
Contributor Author

roiLeo commented Nov 16, 2022

It's supplemental pr or replacing #4318 ?

sorry it's replacing

@Jarsen136 Jarsen136 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Nov 16, 2022
@yangwao
Copy link
Member

yangwao commented Nov 16, 2022

yess

@yangwao yangwao merged commit 4a78cb5 into kodadot:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wider actionable space for buttons in navbar
3 participants