Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 navbar item dark mode hover state #4343

Merged
merged 1 commit into from
Nov 16, 2022
Merged

🔧 navbar item dark mode hover state #4343

merged 1 commit into from
Nov 16, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Nov 16, 2022 •
edited

Didn't catch it on my screen
Should we remove focus background color too?

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

@roiLeo roiLeo requested a review from a team as a code owner November 16, 2022 15:00
@roiLeo roiLeo requested review from Jarsen136 and removed request for a team November 16, 2022 15:00
@netlify
Copy link

netlify bot commented Nov 16, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 3504f4a
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/6374faf4987628000825a93b
😎 Deploy Preview https://deploy-preview-4343--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Nov 16, 2022

Code Climate has analyzed commit 3504f4a and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Nov 16, 2022

@yangwao yangwao added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Nov 16, 2022
@yangwao yangwao merged commit 0a7802b into kodadot:main Nov 16, 2022
@exezbcz
Copy link
Member

exezbcz commented Nov 17, 2022

its happening again. New issue created

@roiLeo roiLeo deleted the fix/navbar/darkModeItemHover branch November 17, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expanded container colors
3 participants
@roiLeo @yangwao @exezbcz