Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: profile dropdown text color in light mode #4346

Merged
merged 7 commits into from
Nov 21, 2022

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Nov 17, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    image

@daiagi daiagi requested a review from a team as a code owner November 17, 2022 11:25
@daiagi daiagi requested review from prachi00 and removed request for a team November 17, 2022 11:25
@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 203a8d9
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/637a2dc160a76e00089faf09
😎 Deploy Preview https://deploy-preview-4346--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Nov 17, 2022

SUCCESS @daiagi PR for issue #4345 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@exezbcz
Copy link
Member

exezbcz commented Nov 17, 2022

its still showing the wrong color text color
image

@daiagi
Copy link
Contributor Author

daiagi commented Nov 17, 2022

its still showing the wrong color text color

Done

image

@yangwao
Copy link
Member

yangwao commented Nov 17, 2022

Hey, I guess we should more likely use scoped CSS than !important ?

@daiagi hey try your best and I'm willing raise bounty for this 😎

@roiLeo
Copy link
Contributor

roiLeo commented Nov 17, 2022

Hey, I guess we should more likely use scoped CSS than !important ?

family-guy-css

@yangwao yangwao added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Nov 17, 2022
@daiagi
Copy link
Contributor Author

daiagi commented Nov 18, 2022

Hi guys
I didn't use scoped CSS
but i simplified _light.scss, removed dead css and removed !important

Visual Differences:
⚡ hover color on explore and on chain select (it was missing before)
image

⚡ text color in drop downs, as requested:
image
image
image

@roiLeo
Copy link
Contributor

roiLeo commented Nov 18, 2022

FYI there are sass variables that can be defined

@daiagi
Copy link
Contributor Author

daiagi commented Nov 19, 2022

FYI there are sass variables that can be defined

Very good tip. thank you
unfortunately it only works if the variables are defined in global scope.

this doesn't work:

@import "abstracts/variables";
@import "abstracts/animations";
@import "abstracts/fonts";


html.light-mode{
    $navbar-item-color: $text-light-theme;
    $navbar-item-hover-color: $primary-light;
}


// FRAMEWORK (note: don't move this on top)
@import "~bulma";
@import "~buefy/src/scss/buefy";
@import "~@oruga-ui/oruga/src/scss/oruga";

@exezbcz
Copy link
Member

exezbcz commented Nov 20, 2022

not sure whether its related to this issue but in the deploy preview the color of text in wallet dropdown is incorrect
image

@codeclimate
Copy link

codeclimate bot commented Nov 20, 2022

Code Climate has analyzed commit 203a8d9 and detected 0 issues on this pull request.

View more on Code Climate.

@daiagi
Copy link
Contributor Author

daiagi commented Nov 20, 2022

not sure whether its related to this issue but in the deploy preview the color of text in wallet dropdown is incorrect

Jesus... how the ### did i miss that?!
it's fixed
sorry for wasting your time 😞

image

@yangwao
Copy link
Member

yangwao commented Nov 20, 2022

lal nice identicon! love it
image

I mean, let's put it out to beta
pay 80 USD for extra will and quick reactions!

@yangwao yangwao added paid pull-request has been paid and removed paid pull-request has been paid labels Nov 20, 2022
@yangwao
Copy link
Member

yangwao commented Nov 20, 2022

oh need to replenish payout stuff >.>

@yangwao
Copy link
Member

yangwao commented Nov 21, 2022

pay 80 usd

@yangwao
Copy link
Member

yangwao commented Nov 21, 2022

😍 Perfect, I’ve sent the payout
💵 $80 @ 24.11 USD/KSM ~ 3.318 $KSM
🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L
🔗 0xdb9a64798e82ae71bf6afc5a4581af5d5ec0e6abf6dbdc6c2c641a949a04d202

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 21, 2022
@yangwao yangwao merged commit 9fb0199 into kodadot:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

profile dropdown text color
5 participants