Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: More from this collection & Visited NFTS show 0 KSM #4352

Merged
merged 3 commits into from
Nov 18, 2022
Merged

fix: More from this collection & Visited NFTS show 0 KSM #4352

merged 3 commits into from
Nov 18, 2022

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner November 17, 2022 16:16
@Jarsen136 Jarsen136 requested review from prachi00 and removed request for a team November 17, 2022 16:16
@netlify
Copy link

netlify bot commented Nov 17, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 4e896a6
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/637672e9d90e7b0008e8befc
😎 Deploy Preview https://deploy-preview-4352--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Nov 17, 2022

SUCCESS @Jarsen136 PR for issue #4350 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@prachi00 prachi00 added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Nov 17, 2022
@codeclimate
Copy link

codeclimate bot commented Nov 17, 2022

Code Climate has analyzed commit 4e896a6 and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@roiLeo roiLeo added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Nov 18, 2022
@yangwao
Copy link
Member

yangwao commented Nov 18, 2022

pay 50 usd

@yangwao yangwao merged commit 880dde2 into kodadot:main Nov 18, 2022
@yangwao
Copy link
Member

yangwao commented Nov 18, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 24.29 USD/KSM ~ 2.058 $KSM
🧗 Caiv9TbPz68q5dC8EcHu5xKYPRnremimGzqmEejDFNpWWLG
🔗 0xa85f35bf4b10480634f03e24d9a005518ec211325a72b6799a679896a30b5c9f

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 18, 2022
@roiLeo roiLeo mentioned this pull request Nov 22, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@prachi00 prachi00 prachi00 approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More from this collection & Visited NFTS show 0 KSM
5 participants
@Jarsen136 @kodabot @yangwao @roiLeo @prachi00