Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 toast style change #4374

Merged
merged 3 commits into from
Nov 22, 2022
Merged

🔧 toast style change #4374

merged 3 commits into from
Nov 22, 2022

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Nov 22, 2022

Text feels a bit small now

PR Type

  • Bugfix

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot 📸

light
Screenshot 2022-11-22 at 08-39-33 KodaDot - Kusama NFT Market Explorer

dark
Screenshot 2022-11-22 at 08-39-15 KodaDot - Kusama NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner November 22, 2022 07:44
@roiLeo roiLeo requested review from Jarsen136 and removed request for a team November 22, 2022 07:44
@netlify
Copy link

netlify bot commented Nov 22, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 231c12a
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/637c964cf6393f00084fd858
😎 Deploy Preview https://deploy-preview-4374--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yangwao
Copy link
Member

yangwao commented Nov 22, 2022

I was thinking if we would position it bit lower so it doesn't overlap with searchbar?

@roiLeo
Copy link
Contributor Author

roiLeo commented Nov 22, 2022

I was thinking if we would position it bit lower so it doesn't overlap with searchbar?

Where?
Screenshot 2022-11-22 at 10-25-20 KodaDot - Kusama NFT Market Explorer

@roiLeo
Copy link
Contributor Author

roiLeo commented Nov 22, 2022

Updated!
Screenshot 2022-11-22 at 10-28-08 KodaDot - Kusama NFT Market Explorer

@codeclimate
Copy link

codeclimate bot commented Nov 22, 2022

Code Climate has analyzed commit 231c12a and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Nov 22, 2022

yes probably works!

I guess we will redesign whole notification system anyway.
So probably we then keep all this at one place for simplicity of user interactions :)

@yangwao yangwao merged commit 0286f8b into kodadot:main Nov 22, 2022
@roiLeo roiLeo deleted the fix/toast/style branch November 22, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants