Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ enter key icon in search bar #4392

Merged
merged 4 commits into from
Nov 24, 2022
Merged

✨ enter key icon in search bar #4392

merged 4 commits into from
Nov 24, 2022

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Nov 23, 2022 •
edited

PR Type

Refactoring

Context

Closes #4387

Had issue bounty label?

  • Fill up your KSM address: Payout

Screenshot 📸

image
image

@netlify
Copy link

netlify bot commented Nov 23, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 81945ac
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/637f7ad734400100092e6d63
😎 Deploy Preview https://deploy-preview-4392--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shashkovdanil shashkovdanil marked this pull request as ready for review November 23, 2022 23:23
@shashkovdanil shashkovdanil requested a review from a team as a code owner November 23, 2022 23:23
@shashkovdanil shashkovdanil requested review from roiLeo and removed request for a team November 23, 2022 23:23
roiLeo
roiLeo reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Something strange happen on first click, could you take a look

Enregistrement.de.l.ecran.2022-11-24.a.8.37.38.AM.mov

@shashkovdanil
Copy link
Contributor Author

Hey! I'll check

@shashkovdanil
Copy link
Contributor Author

@roiLeo Screencast: https://monosnap.com/file/O8Lk1smhEP2V45XITZN2ZtsmeYrICc

roiLeo
roiLeo reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could try to toggle visibility with is-invisible class

height on k-search-enter.svg is not the one defined (should be same height as the other one)
Capture d’écran 2022-11-24 à 1 48 55 PM

@shashkovdanil
Copy link
Contributor Author

image

@codeclimate
Copy link

codeclimate bot commented Nov 24, 2022

Code Climate has analyzed commit 81945ac and detected 0 issues on this pull request.

View more on Code Climate.

roiLeo
roiLeo approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

✅ code lgtm & wfm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Nov 24, 2022
@yangwao
Copy link
Member

yangwao commented Nov 24, 2022

pay 30 usd

yesss

@yangwao yangwao merged commit fc9aaf8 into kodadot:main Nov 24, 2022
@yangwao
Copy link
Member

yangwao commented Nov 24, 2022

😍 Perfect, I’ve sent the payout
💵 $30 @ 26.07 USD/KSM ~ 1.151 $KSM
🧗 bXn3ExwLs8rpcpknp9wNqnNVgEYVLnTtFPDrJtaPHYds7Vfjv
🔗 0x7c8cab07c4e3aa6f13e882fd5e9efbf7007a3f17367c67d1ea54bfe13a9f4624

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button in searchbar need some love
3 participants
@shashkovdanil @yangwao @roiLeo