Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 unable to create collection in Basilisk #4400

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Nov 24, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

Preface

When Basilisk got stuck, they upgraded the code with new version that renamed call from createClass to createCollection. So than app was unable to find that call

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Screenshot

Screenshot 2022-11-24 at 12 42 17

@vikiival vikiival requested a review from a team as a code owner November 24, 2022 12:44
@vikiival vikiival requested review from Jarsen136 and removed request for a team November 24, 2022 12:44
@netlify
Copy link

netlify bot commented Nov 24, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit c6babb7
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/637f6afe8361e300096fa700
😎 Deploy Preview https://deploy-preview-4400--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codeclimate
Copy link

codeclimate bot commented Nov 24, 2022

Code Climate has analyzed commit c6babb7 and detected 0 issues on this pull request.

View more on Code Climate.

@vikiival vikiival merged commit b0045d4 into main Nov 24, 2022
@vikiival vikiival deleted the 4399-universe-sent-snek branch November 24, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to mint new collection on Basilisk
2 participants