Fix nft details in carousel

[shashkovdanil]

Important!

This fix works well, but it's temporary. The backend developers need to figure out why the metadata is empty for some NFTs.

PR Type

Bugfix

Context

• Related Item/Video on landing doesn't show but it does shows on item detail #4169

Had issue bounty label?

• Fill up your KSM address: Payout

Screenshot 📸

https://monosnap.com/file/jNQh60q7PLkfXgzjKY3JPLiPF5Zsjb

[kodabot]

SUCCESS @shashkovdanil PR for issue #4169 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

[netlify]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	9a32d0f
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/6384d5bac20c8b0008a12f94
😎 Deploy Preview	https://deploy-preview-4413--koda-nuxt.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[yangwao]

The backend developers need to figure out why the metadata is empty for some NFTs.

I would check here?

• Refetch metadata snek#102

[shashkovdanil]

The backend developers need to figure out why the metadata is empty for some NFTs.

I would check here?

• Refetch metadata snek#102

Yep, that's it. I would look at it myself, but I'm afraid I don't have enough experience to figure it out on my own in a normal amount of time.

[roiLeo]

Here's the issue category breakdown:
Category Count
Complexity 1

Could you find a way to reduce numbers of line for formatNFT method?

[shashkovdanil]

@roiLeo think I can, but it will make the code unreadable. GitHub shows that I made many changes because I wrapped data.map in Promise.all(data.map). In fact my changes are:

if (metaImage === null) {
  const cachedMeta = await get(nft.metadata)
  const meta = !isEmpty(cachedMeta)
    ? cachedMeta
    : await fetchNFTMetadata(
        nft,
        getSanitizer(nft.metadata, 'pinata', 'permafrost')
      )
  const imageSanitizer = getSanitizer(meta.image, 'pinata')

  return {
    ...result,
    name: meta.name,
    image: imageSanitizer(meta.image),
    animation_url: sanitizeIpfsUrl(
      meta.animation_url || meta.image,
      'pinata'
    ),
  }
}

[shashkovdanil]

@roiLeo any updates?

[roiLeo]

set in idb new meta val if present

missing setter for idb storage

if (!cachedMeta) {
  set(nft.metadata, meta)
}

[shashkovdanil]

set in idb new meta val if present

missing setter for idb storage

if (!cachedMeta) {
  set(nft.metadata, meta)
}

Done

[roiLeo]

rest looks good to me

[codeclimate]

Code Climate has analyzed commit 9a32d0f and detected 0 issues on this pull request.

View more on Code Climate.

[roiLeo]

✅ code lgtm

[shashkovdanil]

Can it be merged?

[shashkovdanil]

cc @roiLeo @preschian

[roiLeo]

It need 2nd approval to merge this, Team is currently busy with ongoing event.
In the meantime feel free to take another issue

[yangwao]

Team is currently busy with ongoing event.

[yangwao]

pay 60 usd

Team is currently busy with ongoing event.

Yes, we are again in Lisbon.
If you want to come over to Polkadot barcamp today/tmrw, you are welcome!

• https://incongruous-riverbed-10f.notion.site/Polkadot-Summit-Barcamp-ffbadaef52574e4db8bab53d9e9d50b4

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $60 @ 28.2 USD/KSM ~ 2.128 $KSM
🧗 bXn3ExwLs8rpcpknp9wNqnNVgEYVLnTtFPDrJtaPHYds7Vfjv
🔗 0xeae912266df78e9cd51491cfcb4ff228fedea7428dc1a73610794707b2df8a00

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues