Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 green glow begone! #4423

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

petersopko
Copy link
Contributor

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested it at </bsx/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

My NFT on BSX:
image

@petersopko petersopko requested a review from a team as a code owner November 26, 2022 15:36
@petersopko petersopko requested review from Jarsen136 and removed request for a team November 26, 2022 15:36
@netlify
Copy link

netlify bot commented Nov 26, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 312adad
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/638232736607e6000839ae6b
😎 Deploy Preview https://deploy-preview-4423--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Nov 26, 2022

SUCCESS @petersopko PR for issue #4422 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@codeclimate
Copy link

codeclimate bot commented Nov 26, 2022

Code Climate has analyzed commit 312adad and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@vikiival
Copy link
Member

Hey, maybe check if the code is not repeated on other components?

Otherwise LGTM

@petersopko
Copy link
Contributor Author

Hey, maybe check if the code is not repeated on other components?

Otherwise LGTM

I didn't find any other places where it was used, I think it's okay like this.

@yangwao yangwao added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Nov 30, 2022
@yangwao
Copy link
Member

yangwao commented Nov 30, 2022

pay 30

@yangwao yangwao merged commit 711ceef into kodadot:main Nov 30, 2022
@yangwao
Copy link
Member

yangwao commented Nov 30, 2022

😍 Perfect, I’ve sent the payout
💵 $30 @ 28.15 USD/KSM ~ 1.066 $KSM
🧗 FNyt7T1xdbhN7dagf7yGYCRJuE3R45VmTCE3tjzy1rKxa7y
🔗 0xbb32555b11c0502b538971cdc843bd322bc317fa22aa1010a987920d8e7af809

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove green glow
5 participants