Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update search bar visibility and disable scroll on burger menu #4432

Merged
merged 5 commits into from
Dec 3, 2022
Merged

update search bar visibility and disable scroll on burger menu #4432

merged 5 commits into from
Dec 3, 2022

Conversation

yeshealer
Copy link
Contributor

@yeshealer yeshealer commented Nov 30, 2022 •
edited by yangwao

@yeshealer yeshealer requested a review from a team as a code owner November 30, 2022 18:09
@yeshealer yeshealer requested review from Jarsen136 and removed request for a team November 30, 2022 18:09
@netlify
Copy link

netlify bot commented Nov 30, 2022 •
edited

✅ Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit f14c3a4
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/638a14bc461f0a000b4fa3fe
😎 Deploy Preview https://deploy-preview-4432--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Jarsen136
Jarsen136 requested changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a bug report issue first 👀

components/Navbar.vue Outdated Show resolved Hide resolved
components/Navbar.vue Outdated Show resolved Hide resolved
@Jarsen136 Jarsen136 added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Dec 1, 2022
@yeshealer
Copy link
Contributor Author

#4429

Jarsen136
Jarsen136 reviewed Dec 1, 2022
View reviewed changes
components/Navbar.vue Outdated Show resolved Hide resolved
components/Navbar.vue Outdated Show resolved Hide resolved
@yangwao
Copy link
Member

yangwao commented Dec 1, 2022

@yeshealer can you please update the text of PR with the issue number?

#4429

@yeshealer yeshealer changed the title update search bar visibility and disable scroll on burger menu #4429 Dec 1, 2022
@yeshealer
Copy link
Contributor Author

@yeshealer can you please update the text of PR with the issue number?

updated @yangwao

@yangwao
Copy link
Member

yangwao commented Dec 1, 2022

oh, I mean description 😅

@yeshealer yeshealer changed the title #4429 update search bar visibility and disable scroll on burger menu Dec 2, 2022
@yeshealer
Copy link
Contributor Author

yeshealer commented Dec 2, 2022 •
edited

oh, I mean description 😅

haha... I see I see. changed

@yeshealer
Copy link
Contributor Author

yeshealer commented Dec 2, 2022 •
edited

I think it's ready to merge
@yangwao @Jarsen136

@Jarsen136
Copy link
Contributor

Jarsen136 commented Dec 2, 2022 •
edited

I think it's ready to merge

Please check the comment #4432 (comment)

@codeclimate
Copy link

codeclimate bot commented Dec 2, 2022

Code Climate has analyzed commit f14c3a4 and detected 0 issues on this pull request.

View more on Code Climate.

@yeshealer
Copy link
Contributor Author

Please check the comment #4432 (comment)

Solved it

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Dec 3, 2022
@yangwao yangwao disabled auto-merge December 3, 2022 14:57
@yangwao yangwao merged commit c3030c1 into kodadot:main Dec 3, 2022
@yangwao
Copy link
Member

yangwao commented Dec 3, 2022

pay 50 usd

@yeshealer
Copy link
Contributor Author

yeshealer commented Dec 3, 2022 •
edited

pay 50 usd

https://kodadot.xyz/transfer/?target=EipjuPLU8F3435MGCaS972u7wxwhvi3H8KzJ1e95qWEDtKM @yangwao

@yangwao
Copy link
Member

yangwao commented Dec 6, 2022

pay 50 usd

@yangwao
Copy link
Member

yangwao commented Dec 6, 2022

pay 50 usd
hmm something doens't work, tried put it in your pr

@yangwao
Copy link
Member

yangwao commented Dec 6, 2022

😍 Perfect, I’ve sent the payout
💵 $50 @ 30.87 USD/KSM ~ 1.62 $KSM
🧗 EipjuPLU8F3435MGCaS972u7wxwhvi3H8KzJ1e95qWEDtKM
🔗 0x03a671186eb9811d50c54c094b4c1e8a2f79b736d1f52ed2fbe1c04685b69b3b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Dec 6, 2022
@yeshealer
Copy link
Contributor Author

confirmed. @yangwao
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarsen136 Jarsen136 Jarsen136 approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong scroll behaviour on mobile
3 participants
@yeshealer @yangwao @Jarsen136