Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4441 Add close option into search navbar on mobile #4448

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

vkbishu
Copy link
Contributor

@vkbishu vkbishu commented Dec 5, 2022

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

  • Feature

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality
  • I've posted a screenshot of demonstrated change in this PR

Optional

  • I've tested PR on mobile

Had issue bounty label?

  • Fill up your KSM address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screen Shot 2022-12-05 at 21 05 46 PM

@vkbishu vkbishu requested a review from a team as a code owner December 5, 2022 15:37
@vkbishu vkbishu requested review from preschian and removed request for a team December 5, 2022 15:37
@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for koda-nuxt ready!

Name Link
🔨 Latest commit 2716e82
🔍 Latest deploy log https://app.netlify.com/sites/koda-nuxt/deploys/638f140a31dc800008ba7c4e
😎 Deploy Preview https://deploy-preview-4448--koda-nuxt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kodabot
Copy link
Collaborator

kodabot commented Dec 5, 2022

SUCCESS @vkbishu PR for issue #4441 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@preschian preschian added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Dec 6, 2022
@codeclimate
Copy link

codeclimate bot commented Dec 6, 2022

Code Climate has analyzed commit 2716e82 and detected 0 issues on this pull request.

View more on Code Climate.

@yangwao
Copy link
Member

yangwao commented Dec 6, 2022

Brilliant

fill up your payout address please 🥺

@yangwao yangwao merged commit 7e8c570 into kodadot:main Dec 6, 2022
@exezbcz
Copy link
Member

exezbcz commented Dec 6, 2022

dark mode does not look ok
image

@vkbishu
Copy link
Contributor Author

vkbishu commented Dec 6, 2022

Brilliant

fill up your payout address please 🥺

Thanks @yangwao

https://kodadot.xyz/transfer?target=GhvqRXYu6pywEkdCzyuoUrEgaKkUML2mCW9dWz7wniQtcMw

@vkbishu
Copy link
Contributor Author

vkbishu commented Dec 6, 2022

dark mode does not look ok image

@exezbcz Ohh. Didn't find the dark mode option. Should I create a separate PR for this fix?

@vkbishu vkbishu deleted the close-option-navbar-mobile branch December 7, 2022 06:17
@petersopko petersopko mentioned this pull request Dec 7, 2022
@preschian
Copy link
Member

dark mode does not look ok

oopps, I missed that as a reviewer

@exezbcz Ohh. Didn't find the dark mode option. Should I create a separate PR for this fix?

@vkbishu yes, feel free to create a separate PR for the fix

@vkbishu
Copy link
Contributor Author

vkbishu commented Dec 7, 2022

@preschian I think @petersopko is already working on this. #4451 (comment) .

@petersopko Please confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add close option into search navbar on mobile
5 participants